Bugzilla – Attachment 88920 Details for
Bug 15496
Delete bibliographic record after moving last item to another record(s)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15496: (QA follow-up) Restore Koha::Biblio->items broken by rebase
Bug-15496-QA-follow-up-Restore-KohaBiblio-items-br.patch (text/plain), 1.21 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-04-26 13:20:45 UTC
(
hide
)
Description:
Bug 15496: (QA follow-up) Restore Koha::Biblio->items broken by rebase
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-04-26 13:20:45 UTC
Size:
1.21 KB
patch
obsolete
>From 2fd0a85858dc0ace14a5e4478a08c0411f8d0ddf Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 26 Apr 2019 10:19:07 -0300 >Subject: [PATCH] Bug 15496: (QA follow-up) Restore Koha::Biblio->items broken > by rebase > >This patch restores the implementation introduced by 22701. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Biblio.pm | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > >diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm >index 688edc85ae..9591553951 100644 >--- a/Koha/Biblio.pm >+++ b/Koha/Biblio.pm >@@ -350,9 +350,11 @@ sub article_requests_finished { > > =head3 items > >+my @items = $biblio->items(); > my $items = $biblio->items(); > >-Returns the related Koha::Items object for this biblio >+Returns the related Koha::Items object for this biblio in scalar context, >+or list of Koha::Item objects in list context. > > =cut > >@@ -361,9 +363,13 @@ sub items { > > my $items_rs = $self->_result->items; > >- return Koha::Items->_new_from_dbic( $items_rs ); >+ return >+ wantarray >+ ? Koha::Items->_new_from_dbic($items_rs)->as_list >+ : Koha::Items->_new_from_dbic($items_rs); > } > >+ > =head3 itemtype > > my $itemtype = $biblio->itemtype(); >-- >2.21.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15496
:
88004
|
88005
|
88006
|
88008
|
88015
|
88016
|
88017
|
88018
|
88019
|
88020
|
88026
|
88027
|
88028
|
88029
|
88030
|
88031
|
88032
|
88165
|
88166
|
88167
|
88168
|
88169
|
88170
|
88171
|
88172
|
88215
|
88225
|
88226
|
88227
|
88228
|
88229
|
88230
|
88892
|
88893
|
88894
|
88895
|
88896
|
88897
|
88903
|
88905
|
88920
|
88938
|
88950