Attachment 88921 Details for Bug 22461 – Bug 22461: (follow-up) Use `exists` not `defined`

[patch] Bug 22461: (follow-up) Use `exists` not `defined`

Bug-22461-follow-up-Use-exists-not-defined.patch (text/plain), 1.09 KB, created by Martin Renvoize (ashimema) on 2019-04-26 13:37:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-04-26 13:37:05 UTC

Size: 1.09 KB

patch

obsolete

>From b03cf85246b98c45f6dde2671c5616adb8798238 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 26 Apr 2019 14:35:18 +0100
>Subject: [PATCH] Bug 22461: (follow-up) Use `exists` not `defined`
>
>Prior to this patch there is a regression in the LDAP replication
>functionality such that clearing a field become impossible. This patch
>restores that functionality.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Auth_with_ldap.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm
>index 589dbcc68f..6f3b9a3828 100644
>--- a/C4/Auth_with_ldap.pm
>+++ b/C4/Auth_with_ldap.pm
>@@ -224,7 +224,7 @@ sub checkpw_ldap {
>         my @columns = Koha::Patrons->columns;
>         my $patron = Koha::Patron->new(
>             {
>-                map { defined( $borrower{$_} ) ? ( $_ => $borrower{$_} ) : () } @columns
>+                map { exists( $borrower{$_} ) ? ( $_ => $borrower{$_} ) : () } @columns
>             }
>         )->store;
>         die "Insert of new patron failed" unless $patron;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22461: 86696 | 86697 | 86856 | 87721 | 87722 | 87723 | 88192 | 88193 | 88194 | 88921