Attachment 8896 Details for Bug 7613 – Bug 7613 follow up to fix perlcritic errors

[patch] Bug 7613 follow up to fix perlcritic errors

Bug-7613-follow-up-to-fix-perlcritic-errors.patch (text/plain), 1.28 KB, created by Chris Cormack on 2012-04-05 02:28:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2012-04-05 02:28:48 UTC

Size: 1.28 KB

patch

obsolete

>From 2ebce1d840d29ced35adee714bcfe4ba25225d92 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Thu, 5 Apr 2012 14:28:06 +1200
>Subject: [PATCH] Bug 7613 follow up to fix perlcritic errors
>
>---
> misc/bin/connexion_import_daemon.pl |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/misc/bin/connexion_import_daemon.pl b/misc/bin/connexion_import_daemon.pl
>index ffc1bcf..9d32f8a 100755
>--- a/misc/bin/connexion_import_daemon.pl
>+++ b/misc/bin/connexion_import_daemon.pl
>@@ -112,11 +112,11 @@ sub parse_config {
> 
>     my $config_file = $self->{config_file};
> 
>-    open CONF, $config_file or die "Cannot open config file $config: $!";
>+    open (my $conf_fh, '<', $config_file) or die "Cannot open config file $config: $!";
> 
>     my %param;
>     my $line = 0;
>-    while (<CONF>) {
>+    while (<$conf_fh>) {
>         $line++;
>         chomp;
>         s/\s*#.*//o; # remove comments
>@@ -145,7 +145,7 @@ sub parse_config {
>     my $log_fh;
>     close $self->{log_fh} if $self->{log_fh};
>     if (my $logfile = delete $param{log}) {
>-        open $log_fh, ">>$logfile" or die "Cannot open $logfile for write: $!";
>+        open ($log_fh, '>>', $logfile) or die "Cannot open $logfile for write: $!";
>     } else {
>         $log_fh = \*STDERR;
>     }
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 7613: 8194 | 8256 | 8268 | 8269 | 8270 | 8328 | 8523 | 8527 | 8550 | 8678 | 8691 | 8896 | 10240