Bugzilla – Attachment 89005 Details for
Bug 22478
Cross-site scripting vulnerability in paginations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean
Bug-22478-QA-follow-up-Handle-category-in-opac-she.patch (text/plain), 1.65 KB, created by
Martin Renvoize (ashimema)
on 2019-04-29 09:33:52 UTC
(
hide
)
Description:
Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-04-29 09:33:52 UTC
Size:
1.65 KB
patch
obsolete
>From 3847d93b645f6fbabfb81327cafc25fe043c3099 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 12 Apr 2019 07:02:06 +0000 >Subject: [PATCH] Bug 22478: (QA follow-up) Handle category in opac-shelves > like a boolean > >The category parameter should be restricted to 1 or 2 (private/public). In >order to keep same behavior, no parameter means 1 (private). >Note: Adding the same line in intranet counterpart. > >Test plan >[1] Check for category empty, '1a', '11' etc. And with script ;) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > opac/opac-shelves.pl | 1 + > virtualshelves/shelves.pl | 1 + > 2 files changed, 2 insertions(+) > >diff --git a/opac/opac-shelves.pl b/opac/opac-shelves.pl >index ab1a835c08..41dc3826f9 100755 >--- a/opac/opac-shelves.pl >+++ b/opac/opac-shelves.pl >@@ -60,6 +60,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ > my $op = $query->param('op') || 'list'; > my $referer = $query->param('referer') || $op; > my $category = $query->param('category') || 1; >+$category = 2 if $category ne "1"; > my ( $shelf, $shelfnumber, @messages ); > > if ( $op eq 'add_form' ) { >diff --git a/virtualshelves/shelves.pl b/virtualshelves/shelves.pl >index 495f4429b3..9348ffbf96 100755 >--- a/virtualshelves/shelves.pl >+++ b/virtualshelves/shelves.pl >@@ -51,6 +51,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > my $op = $query->param('op') || 'list'; > my $referer = $query->param('referer') || $op; > my $category = $query->param('category') || 1; >+$category = 2 if $category ne "1"; > my ( $shelf, $shelfnumber, @messages ); > > if ( $op eq 'add_form' ) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22478
:
86636
|
86683
|
87697
|
87698
|
87699
|
87700
|
87701
|
87841
|
87842
|
87843
|
87844
|
88937
|
88954
|
89002
|
89003
|
89004
| 89005 |
89006
|
89009
|
89453