Bugzilla – Attachment 89006 Details for
Bug 22478
Cross-site scripting vulnerability in paginations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22478: (QA follow-up) Make test consistent with variable name
Bug-22478-QA-follow-up-Make-test-consistent-with-v.patch (text/plain), 2.04 KB, created by
Martin Renvoize (ashimema)
on 2019-04-29 09:33:55 UTC
(
hide
)
Description:
Bug 22478: (QA follow-up) Make test consistent with variable name
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-04-29 09:33:55 UTC
Size:
2.04 KB
patch
obsolete
>From 34b18e91ed398d744ed4c570daca6ddef630e051 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 26 Apr 2019 19:56:43 +0100 >Subject: [PATCH] Bug 22478: (QA follow-up) Make test consistent with variable > name > >We were adding data to category 1 (private lists) and testing against >that, but we named the variable 'publist_lists'. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/selenium/regressions.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index 911314d272..7901cb9e03 100644 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -195,7 +195,7 @@ subtest 'XSS vulnerabilities in pagination' => sub { > { > class => 'Koha::Virtualshelves', > value => { >- category => 1, >+ category => 2, > allow_change_from_owner => 1, > allow_change_from_others => 0, > owner => $patron->borrowernumber >@@ -209,7 +209,7 @@ subtest 'XSS vulnerabilities in pagination' => sub { > $patron->set_password({ password => $password }); > $s->opac_auth( $patron->userid, $password ); > >- my $public_lists = $s->opac_base_url . q|opac-shelves.pl?op=list&category=1|; >+ my $public_lists = $s->opac_base_url . q|opac-shelves.pl?op=list&category=2|; > $driver->get($public_lists); > > $s->remove_error_handler; >@@ -218,7 +218,7 @@ subtest 'XSS vulnerabilities in pagination' => sub { > is( $alert_text, undef, 'No alert box displayed' ); > > my $booh_alert = 'booh!'; >- $public_lists = $s->opac_base_url . qq|opac-shelves.pl?op=list&category=1"><script>alert('$booh_alert')</script>|; >+ $public_lists = $s->opac_base_url . qq|opac-shelves.pl?op=list&category=2"><script>alert('$booh_alert')</script>|; > $driver->get($public_lists); > > $s->remove_error_handler; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22478
:
86636
|
86683
|
87697
|
87698
|
87699
|
87700
|
87701
|
87841
|
87842
|
87843
|
87844
|
88937
|
88954
|
89002
|
89003
|
89004
|
89005
| 89006 |
89009
|
89453