Attachment 89022 Details for Bug 18928 – Bug 18928: (follow-up) Unset max_holds rule if needed

[patch] Bug 18928: (follow-up) Unset max_holds rule if needed

Bug-18928-follow-up-Unset-maxholds-rule-if-needed.patch (text/plain), 1.42 KB, created by Jonathan Druart on 2019-04-29 15:21:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-04-29 15:21:40 UTC

Size: 1.42 KB

patch

obsolete

>From 9690ec7d3b1885257ecf27ad74974b8bf24e47a5 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Wed, 24 Apr 2019 21:11:29 +0000
>Subject: [PATCH] Bug 18928: (follow-up) Unset max_holds rule if needed
>
>Test plan:
>1) Set all values in Default checkout, hold and return policy section on
>circulation rules admin page, try for all libraries and for one specific
>library. Save.
>2) Click on unset and confitm
>--> without patch, the Maximum total holds allowed value remains
>--> with patch the unset removex Maximum holds value too
>---
> admin/smart-rules.pl | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
>index 41c61f733d..2bdebc9186 100755
>--- a/admin/smart-rules.pl
>+++ b/admin/smart-rules.pl
>@@ -104,6 +104,7 @@ elsif ($op eq 'delete-branch-cat') {
>                          holdallowed             => undef,
>                          hold_fulfillment_policy => undef,
>                          returnbranch            => undef,
>+                         max_holds               => undef,
>                      }
>                  }
>              );
>@@ -133,6 +134,7 @@ elsif ($op eq 'delete-branch-cat') {
>                     holdallowed             => undef,
>                     hold_fulfillment_policy => undef,
>                     returnbranch            => undef,
>+                    max_holds               => undef,
>                 }
>             }
>         );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18928: 65241 | 65242 | 71005 | 71006 | 81096 | 81097 | 81098 | 81099 | 82933 | 82934 | 82935 | 82936 | 85487 | 85488 | 85489 | 85490 | 85491 | 86134 | 86135 | 86136 | 86137 | 86138 | 86139 | 88659 | 89017 | 89018 | 89019 | 89020 | 89021 | 89022 | 89023 | 89024 | 89333 | 89334 | 89336 | 89338 | 89339 | 89340 | 89341 | 89342 | 89343 | 89344 | 89345 | 89346 | 89347 | 89348 | 89349 | 89377 | 89402 | 89427 | 89428 | 89429 | 89430 | 89431 | 89432 | 89433 | 89434 | 89435 | 89436 | 89437 | 89438 | 89440 | 89441 | 89442 | 89443 | 89444 | 89445 | 89446 | 89447 | 89448 | 89449 | 89450 | 89451 | 89628 | 89629 | 89630 | 89631 | 89632 | 89633 | 89634 | 89635 | 89636 | 89637 | 89638 | 90501 | 91082 | 91083 | 91084 | 91085 | 91086 | 91087 | 91088 | 91089 | 91090 | 91091 | 91092 | 91093 | 91094