Bugzilla – Attachment 89057 Details for
Bug 22717
Google OAuth auto registration error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration
Bug-22717-bug-20287-follow-up-Fix-Google-OpenId-au.patch (text/plain), 1.86 KB, created by
Chris Cormack
on 2019-04-29 21:44:36 UTC
(
hide
)
Description:
Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2019-04-29 21:44:36 UTC
Size:
1.86 KB
patch
obsolete
>From c23319d7dbe8ef2077f4fb387722f33540a62d84 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 26 Apr 2019 20:49:14 -0400 >Subject: [PATCH] Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto > registration > >Silly bug caused by: > commit ef410fd62f279a10687636a4f26babb2c91ecadc > Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber > >Constructors take a hashref! > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > opac/svc/auth/googleopenidconnect | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/svc/auth/googleopenidconnect b/opac/svc/auth/googleopenidconnect >index 2804005f8e..75c8c0cbef 100755 >--- a/opac/svc/auth/googleopenidconnect >+++ b/opac/svc/auth/googleopenidconnect >@@ -196,7 +196,7 @@ elsif ( defined $query->param('code') ) { > if (defined $patron_category && defined $library) { > my $password = undef; > # TODO errors handling! >- my $borrower = Koha::Patron->new( >+ my $borrower = Koha::Patron->new({ > firstname => $firstname, > surname => $surname, > email => $email, >@@ -204,7 +204,7 @@ elsif ( defined $query->param('code') ) { > branchcode => $branchcode, > userid => $userid, > password => $password >- )->store; >+ })->store; > } else { > $error_feedback = 'The GoogleOpenIDConnectDefaultBranch or GoogleOpenIDConnectDefaultCategory system preferences are not configured properly. Please contact the library with this error message.'; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22717
:
88974
| 89057