Attachment 89111 Details for Bug 21872 – Bug 21872: Remove duplicate modulo condition in authorities iterator

[patch] Bug 21872: Remove duplicate modulo condition in authorities iterator

Bug-21872-Remove-duplicate-modulo-condition-in-aut.patch (text/plain), 1.78 KB, created by Martin Renvoize (ashimema) on 2019-04-30 09:31:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-04-30 09:31:20 UTC

Size: 1.78 KB

patch

obsolete

>From 61a324b103965ad90b372c865b459b66f2d7312a Mon Sep 17 00:00:00 2001
>From: David Gustafsson <david.gustafsson@ub.gu.se>
>Date: Thu, 14 Feb 2019 15:59:27 +0100
>Subject: [PATCH] Bug 21872: Remove duplicate modulo condition in authorities
> iterator
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/BiblioUtils.pm              | 2 +-
> Koha/MetadataRecord/Authority.pm | 5 ++---
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/BiblioUtils.pm b/Koha/BiblioUtils.pm
>index 88395a952f..fd6969d8bf 100644
>--- a/Koha/BiblioUtils.pm
>+++ b/Koha/BiblioUtils.pm
>@@ -131,7 +131,7 @@ sub get_all_biblios_iterator {
>     if ($options{slice}) {
>         $slice_count = $options{slice}->{count};
>         $slice_modulo = $options{slice}->{index};
>-        $search_terms = \[ ' mod(biblionumber, ?) = ?', $slice_count, $slice_modulo];
>+        $search_terms = \[ 'mod(biblionumber, ?) = ?', $slice_count, $slice_modulo ];
>     }
> 
>     my $database = Koha::Database->new();
>diff --git a/Koha/MetadataRecord/Authority.pm b/Koha/MetadataRecord/Authority.pm
>index 3a188e7384..17245f0cf4 100644
>--- a/Koha/MetadataRecord/Authority.pm
>+++ b/Koha/MetadataRecord/Authority.pm
>@@ -183,11 +183,10 @@ sub get_all_authorities_iterator {
>     if ($options{slice}) {
>         $slice_count = $options{slice}->{count};
>         $slice_modulo = $options{slice}->{index};
>-        $search_terms->{authid} = \[ ' mod ? = ?', $slice_count, $slice_modulo];
>         $search_terms = {
>             '-and' => [
>-                $search_terms,
>-                \[ ' mod(authid, ?) = ?', $slice_count, $slice_modulo]
>+                %{$search_terms},
>+                \[ 'mod(authid, ?) = ?', $slice_count, $slice_modulo ]
>             ]
>         };
>     }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21872: 82582 | 82583 | 82584 | 82585 | 82586 | 82598 | 82599 | 82780 | 85119 | 85121 | 85975 | 85976 | 85977 | 85978 | 85979 | 86053 | 86054 | 86055 | 86056 | 86057 | 89109 | 89110 | 89111 | 89112 | 89113