Bugzilla – Attachment 89164 Details for
Bug 21036
Fix a bunch of older warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21036: Fix uninitialized value within @itemnumber in string ne
Bug-21036-Fix-uninitialized-value-within-itemnumbe.patch (text/plain), 1.16 KB, created by
Martin Renvoize (ashimema)
on 2019-05-01 09:43:15 UTC
(
hide
)
Description:
Bug 21036: Fix uninitialized value within @itemnumber in string ne
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-05-01 09:43:15 UTC
Size:
1.16 KB
patch
obsolete
>From 1a04f634c1b20007e42b4504e2512a2115b30188 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 4 Jul 2018 16:49:38 +0200 >Subject: [PATCH] Bug 21036: Fix uninitialized value within @itemnumber in > string ne > >Line from 16.11 log: >Use of uninitialized value within @itemnumber in string ne at /usr/share/koha/prodclone/reserve/modrequest.pl line 70. > >Test plan: >Read the change. Not 100% identical (numeric zero) but should be enough. >This line is probably not needed at all. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > reserve/modrequest.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/modrequest.pl b/reserve/modrequest.pl >index 6b4061c724..0d1b2d0262 100755 >--- a/reserve/modrequest.pl >+++ b/reserve/modrequest.pl >@@ -66,7 +66,7 @@ if ($CancelBorrowerNumber) { > # 2) Cancel or modify the queue list of reserves (without item linked) > else { > for (my $i=0;$i<$count;$i++){ >- undef $itemnumber[$i] unless $itemnumber[$i] ne ''; >+ undef $itemnumber[$i] if !$itemnumber[$i]; > ModReserve({ > rank => $rank[$i], > reserve_id => $reserve_id[$i], >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21036
:
76686
|
76689
|
76702
|
76703
|
76704
|
78455
|
78456
|
88969
| 89164 |
89165
|
89166