Attachment 89189 Details for Bug 5770 – Bug 5770: New system pref for new suggestion email

[patch] Bug 5770: New system pref for new suggestion email

Bug-5770-New-system-pref-for-new-suggestion-email.patch (text/plain), 5.93 KB, created by Martin Renvoize (ashimema) on 2019-05-01 18:03:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-05-01 18:03:50 UTC

Size: 5.93 KB

patch

obsolete

>From f0875961d1db713f686dafc380a60ef096808c59 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Nazl=C4=B1=20=C3=87etin?= <nazli@devinim.com.tr>
>Date: Tue, 30 Apr 2019 15:53:20 +0000
>Subject: [PATCH] Bug 5770: New system pref for new suggestion email
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../data/mysql/atomicupdate/bug_5770.perl     | 41 +++++++++++++++++++
> installer/data/mysql/sysprefs.sql             |  2 +
> .../en/modules/admin/preferences/admin.pref   | 11 +++++
> 3 files changed, 54 insertions(+)
> create mode 100644 installer/data/mysql/atomicupdate/bug_5770.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_5770.perl b/installer/data/mysql/atomicupdate/bug_5770.perl
>new file mode 100644
>index 0000000000..12e0d09c9c
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_5770.perl
>@@ -0,0 +1,41 @@
>+$DBversion = '18.12.00.XXX'; # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+    $dbh->do( q{
>+            INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES
>+            ('EmailPurchaseSuggestions','KohaAdminEmailAddress','EmailAddressForSuggestions|BranchEmailAddress|KohaAdminEmailAddress','Choose email address that will be sent new purchase suggestions','Choice'),
>+            ('EmailAddressForSuggestions','','','If you choose EmailAddressForSuggestions you should enter a valid email address','free')
>+    });
>+
>+    $dbh->do( q{
>+            INSERT IGNORE INTO `letter` (module, code, name, title, content, is_html, message_transport_type) VALUES
>+            ('suggestions','NEW_SUGGESTION','New suggestion','New suggestion','<h3>Suggestion pending approval</h3>
>+                <p><h4>Suggested by</h4>
>+                    <ul>
>+                        <li><<borrowers.firstname>> <<borrowers.surname>></li>
>+                        <li><<borrowers.cardnumber>></li>
>+                        <li><<borrowers.phone>></li>
>+                        <li><<borrowers.email>></li>
>+                    </ul>
>+                </p>
>+                <p><h4>Title suggested</h4>
>+                    <ul>
>+                        <li><b>Library:</b> <<branches.branchname>></li>
>+                        <li><b>Title:</b> <<suggestions.title>></li>
>+                        <li><b>Author:</b> <<suggestions.author>></li>
>+                        <li><b>Copyright date:</b> <<suggestions.copyrightdate>></li>
>+                        <li><b>Standard number (ISBN, ISSN or other):</b> <<suggestions.isbn>></li>
>+                        <li><b>Publisher:</b> <<suggestions.publishercode>></li>
>+                        <li><b>Collection title:</b> <<suggestions.collectiontitle>></li>
>+                        <li><b>Publication place:</b> <<suggestions.place>></li>
>+                        <li><b>Quantity:</b> <<suggestions.quantity>></li>
>+                        <li><b>Item type:</b> <<suggestions.itemtype>></li>
>+                        <li><b>Reason for suggestion:</b> <<suggestions.patronreason>></li>
>+                        <li><b>Notes:</b> <<suggestions.note>></li>
>+                    </ul>
>+                </p>',1, 'email')
>+    });
>+
>+    # Always end with this (adjust the bug info)
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 5770 - Email librarian when purchase suggestion made)\n";
>+}
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index eae58f687c..0d50342173 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -158,7 +158,9 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('EasyAnalyticalRecords','0','','If on, display in the catalogue screens tools to easily setup analytical record relationships','YesNo'),
> ('ElasticsearchIndexStatus_authorities', '0', 'Authorities index status', NULL, NULL),
> ('ElasticsearchIndexStatus_biblios', '0', 'Biblios index status', NULL, NULL),
>+('EmailAddressForSuggestions','','',' If you choose EmailAddressForSuggestions you have to enter a valid email address: ','free'),
> ('emailLibrarianWhenHoldIsPlaced','0',NULL,'If ON, emails the librarian whenever a hold is placed','YesNo'),
>+('EmailPurchaseSuggestions','KohaAdminEmailAddress','EmailAddressForSuggestions|BranchEmailAddress|KohaAdminEmailAddress','Choose email address that new purchase suggestions will be sent to: ','Choice'),
> ('EnableAdvancedCatalogingEditor','0','','Enable the Rancor advanced cataloging editor','YesNo'),
> ('EnableBorrowerFiles','0',NULL,'If enabled, allows librarians to upload and attach arbitrary files to a borrower record.','YesNo'),
> ('EnableOpacSearchHistory','1','YesNo','Enable or disable opac search history',''),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>index 5bf920ba25..5347f270a0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>@@ -6,6 +6,17 @@ Administration:
>             - pref: KohaAdminEmailAddress
>               class: email
>             - "(This is the default From: address for emails unless there is one for the particular library, and is referred to when an internal error occurs.)"
>+        -
>+            - "Choose email address that new purchase suggestions will be sent to: "
>+            - pref: EmailPurchaseSuggestions
>+              default: KohaAdminEmailAddress
>+              choices:
>+                  EmailAddressForSuggestions: EmailAddressForSuggestions
>+                  BranchEmailAddress: email address of branch
>+                  KohaAdminEmailAddress: KohaAdminEmailAddress
>+            - "If you choose EmailAddressForSuggestions you have to enter a valid email address: "
>+            - pref: EmailAddressForSuggestions
>+              class: email
>         -
>             - "Email address to be set as the replyto in emails: "
>             - pref: ReplytoDefault
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 5770: 83384 | 83385 | 83386 | 83387 | 83388 | 83390 | 83615 | 83616 | 83617 | 84463 | 84812 | 89139 | 89140 | 89141 | 89142 | 89144 | 89145 | 89146 | 89147 | 89188 | 89189 | 89190 | 89191 | 89192 | 89193 | 89194 | 89195