Attachment 89300 Details for Bug 21671 – Bug 21671: Prevent Modifications.t to fail randomly

[patch] Bug 21671: Prevent Modifications.t to fail randomly

Bug-21671-Prevent-Modificationst-to-fail-randomly.patch (text/plain), 1.53 KB, created by Marcel de Rooy on 2019-05-03 09:23:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-05-03 09:23:31 UTC

Size: 1.53 KB

patch

obsolete

>From d17d2357aaf5bc6253a83086d22e75ffcc311b4d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 12 Nov 2018 15:20:33 -0300
>Subject: [PATCH] Bug 21671: Prevent Modifications.t to fail randomly
>Content-Type: text/plain; charset=utf-8
>
>If repeatable is set to 0 by TestBuilder, the tests will fail with:
>t/db_dependent/Koha/Patron/Modifications.t .. 1/6     # Looks like you planned 20 tests but ran 9.
>
> #   Failed test 'approve tests'
> #   at t/db_dependent/Koha/Patron/Modifications.t line 259.
>[repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5.
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Koha/Patron/Modifications.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Patron/Modifications.t b/t/db_dependent/Koha/Patron/Modifications.t
>index ed4c9b39c6..955de72dbd 100755
>--- a/t/db_dependent/Koha/Patron/Modifications.t
>+++ b/t/db_dependent/Koha/Patron/Modifications.t
>@@ -147,7 +147,7 @@ subtest 'approve tests' => sub {
>         { source => 'BorrowerAttributeType', value => { code => 'CODE_1' } }
>     );
>     $builder->build(
>-        { source => 'BorrowerAttributeType', value => { code => 'CODE_2' } }
>+        { source => 'BorrowerAttributeType', value => { code => 'CODE_2', repeatable => 1 } }
>     );
>     my $verification_token = md5_hex( time().{}.rand().{}.$$ );
>     my $valid_json_text
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21671: 82238 | 89038 | 89300