Attachment 89393 Details for Bug 22812 – Bug 22812: Fix GROUP BY in checkrouting

[patch] Bug 22812: Fix GROUP BY in checkrouting

Bug-22812-Fix-GROUP-BY-in-checkrouting.patch (text/plain), 1.38 KB, created by Jonathan Druart on 2019-05-06 18:52:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-05-06 18:52:30 UTC

Size: 1.38 KB

patch

obsolete

>From 76cf36bcf378057f0b8945c5390fba878bf4954d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 6 May 2019 13:50:54 -0500
>Subject: [PATCH] Bug 22812: Fix GROUP BY in checkrouting
>
>On the way, let fix this error
>DBD::mysql::st execute failed: Mixing of GROUP columns
>(MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is
>no GROUP BY clause [for Statement "SELECT count(routingid) routingids
>FROM subscription LEFT JOIN subscriptionroutinglist
>
>Test plan:
>Create a routing list, search for subscriptions
>In the action list you should see "Edit routing list (1)" or "New
>routing list"
>---
> C4/Serials.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index 1f5a87091e..9f86ab8126 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -1884,7 +1884,7 @@ sub check_routing {
>     my $sth              = $dbh->prepare(
>         "SELECT count(routingid) routingids FROM subscription LEFT JOIN subscriptionroutinglist 
>                               ON subscription.subscriptionid = subscriptionroutinglist.subscriptionid
>-                              WHERE subscription.subscriptionid = ? ORDER BY ranking ASC
>+                              WHERE subscription.subscriptionid = ? GROUP BY routingid ORDER BY ranking ASC
>                               "
>     );
>     $sth->execute($subscriptionid);
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22812: 89391 | 89392 | 89393 | 89454 | 89455 | 89456 | 89535 | 89536 | 89537 | 89561 | 89570 | 89571 | 89572 | 89573 | 89590 | 89591 | 89592 | 89593