Bugzilla – Attachment 89417 Details for
Bug 21411
Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21411: (follow-up) Missing filters and unused variable
Bug-21411-follow-up-Missing-filters-and-unused-var.patch (text/plain), 3.07 KB, created by
Katrin Fischer
on 2019-05-07 08:14:56 UTC
(
hide
)
Description:
Bug 21411: (follow-up) Missing filters and unused variable
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-05-07 08:14:56 UTC
Size:
3.07 KB
patch
obsolete
>From 0fafe109150e141c7749578204510068544b1601 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 4 Mar 2019 11:40:17 -0500 >Subject: [PATCH] Bug 21411: (follow-up) Missing filters and unused variable > >POD warnings from QA tool are false positives (basic functionsn POD not >needed) > >Signed-off-by: Liz Rea <liz@catalyst.net.nz> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/adveditorshortcuts.tt | 6 +++--- > tools/adveditorshortcuts.pl | 1 - > 3 files changed, 5 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt >index 9c49cc867d..90575307a5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt >@@ -279,8 +279,8 @@ > <tbody> > [% FOREACH shortcut IN shortcuts %] > <tr> >- <td>[% shortcut.shortcut_keys %]</td> >- <td>[% shortcut.shortcut_desc %]</td> >+ <td>[% shortcut.shortcut_keys | html %]</td> >+ <td>[% shortcut.shortcut_desc | html %]</td> > </tr> > [% END %] > <tr> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/adveditorshortcuts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/adveditorshortcuts.tt >index c1b98dc3e3..abbc4ac37b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/adveditorshortcuts.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/adveditorshortcuts.tt >@@ -40,10 +40,10 @@ > <tbody> > [% FOREACH shortcut IN shortcuts %] > <tr> >- <td><label for="shortcut_keys">[% shortcut.shortcut_desc %]</label></td> >+ <td><label for="shortcut_keys">[% shortcut.shortcut_desc | html %]</label></td> > <td> >- <input type="hidden" name="shortcut_name" value="[% shortcut.shortcut_name %]"> >- <input type="text" name="shortcut_keys" value="[% shortcut.shortcut_keys %]"> >+ <input type="hidden" name="shortcut_name" value="[% shortcut.shortcut_name | html %]"> >+ <input type="text" name="shortcut_keys" value="[% shortcut.shortcut_keys | html %]"> > </td> > </tr> > [% END %] >diff --git a/tools/adveditorshortcuts.pl b/tools/adveditorshortcuts.pl >index a5162b14d7..6e4279c6a8 100755 >--- a/tools/adveditorshortcuts.pl >+++ b/tools/adveditorshortcuts.pl >@@ -45,7 +45,6 @@ use Koha::KeyboardShortcuts; > > my $input = new CGI; > my $op = $input->param('op') || 'list'; >-my @messages; > > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > { template_name => "tools/adveditorshortcuts.tt", >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21411
:
79408
|
79409
|
85365
|
85366
|
85397
|
85398
|
86012
|
86013
|
86014
|
86018
|
86019
|
86020
|
88465
|
88466
|
88467
|
88468
|
89119
|
89179
|
89416
| 89417 |
89418
|
89419
|
89420
|
89421