Bugzilla – Attachment 89418 Details for
Bug 21411
Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21411: Address QA concerns
Bug-21411-Address-QA-concerns.patch (text/plain), 19.99 KB, created by
Katrin Fischer
on 2019-05-07 08:14:59 UTC
(
hide
)
Description:
Bug 21411: Address QA concerns
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-05-07 08:14:59 UTC
Size:
19.99 KB
patch
obsolete
>From 16a962e8d565c774e54f8cdb479c15e938083ffe Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 23 Apr 2019 11:17:27 +0000 >Subject: [PATCH] Bug 21411: Address QA concerns > >Move to admin >Add a permission >Remove descriptions from table >Clean up template > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Koha/KeyboardShortcuts.pm | 6 ++- > {tools => admin}/adveditorshortcuts.pl | 4 +- > .../Bug_21411_add_keyboard_shortcuts.perl | 35 +++++++++++++++ > .../mysql/atomicupdate/add_keyboard_shortcuts.perl | 30 ------------- > installer/data/mysql/kohastructure.sql | 1 - > .../{en => }/mandatory/keyboard_shortcuts.sql | 24 +++++----- > installer/data/mysql/userpermissions.sql | 1 + > .../intranet-tmpl/prog/en/includes/admin-menu.inc | 3 ++ > .../prog/en/includes/keyboard_shortcuts.inc | 15 +++++++ > .../intranet-tmpl/prog/en/includes/permissions.inc | 5 +++ > .../prog/en/modules/admin/admin-home.tt | 4 ++ > .../modules/{tools => admin}/adveditorshortcuts.tt | 23 +++++----- > .../prog/en/modules/cataloguing/editor.tt | 5 ++- > t/db_dependent/Koha/KeyboardShortcuts.t | 52 ++++++++++++++++++++++ > 14 files changed, 150 insertions(+), 58 deletions(-) > rename {tools => admin}/adveditorshortcuts.pl (93%) > create mode 100644 installer/data/mysql/atomicupdate/Bug_21411_add_keyboard_shortcuts.perl > delete mode 100644 installer/data/mysql/atomicupdate/add_keyboard_shortcuts.perl > rename installer/data/mysql/{en => }/mandatory/keyboard_shortcuts.sql (52%) > create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/keyboard_shortcuts.inc > rename koha-tmpl/intranet-tmpl/prog/en/modules/{tools => admin}/adveditorshortcuts.tt (70%) > create mode 100644 t/db_dependent/Koha/KeyboardShortcuts.t > >diff --git a/Koha/KeyboardShortcuts.pm b/Koha/KeyboardShortcuts.pm >index af26745527..0fb8270ff5 100644 >--- a/Koha/KeyboardShortcuts.pm >+++ b/Koha/KeyboardShortcuts.pm >@@ -35,7 +35,7 @@ Koha::KeyboardShortcuts - Koha KeyboardShortcut Object set class > > =cut > >-=head3 type >+=head3 _type (internal) > > =cut > >@@ -43,6 +43,10 @@ sub _type { > return 'KeyboardShortcut'; > } > >+=head3 object_class (internal) >+ >+=cut >+ > sub object_class { > return 'Koha::KeyboardShortcut'; > } >diff --git a/tools/adveditorshortcuts.pl b/admin/adveditorshortcuts.pl >similarity index 93% >rename from tools/adveditorshortcuts.pl >rename to admin/adveditorshortcuts.pl >index 6e4279c6a8..555ddc9ef6 100755 >--- a/tools/adveditorshortcuts.pl >+++ b/admin/adveditorshortcuts.pl >@@ -47,11 +47,11 @@ my $input = new CGI; > my $op = $input->param('op') || 'list'; > > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >- { template_name => "tools/adveditorshortcuts.tt", >+ { template_name => "admin/adveditorshortcuts.tt", > query => $input, > type => "intranet", > authnotrequired => 1, >- flagsrequired => {}, >+ flagsrequired => { parameters => 'manage_keyboard_shortcuts' }, > debug => 1, > } > ); >diff --git a/installer/data/mysql/atomicupdate/Bug_21411_add_keyboard_shortcuts.perl b/installer/data/mysql/atomicupdate/Bug_21411_add_keyboard_shortcuts.perl >new file mode 100644 >index 0000000000..17c556a12a >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/Bug_21411_add_keyboard_shortcuts.perl >@@ -0,0 +1,35 @@ >+$DBversion = 'XXX'; >+if( CheckVersion( $DBversion ) ) { >+ unless ( TableExists( 'keyboard_shortcuts' ) ) { >+ $dbh->do(q| >+ CREATE TABLE keyboard_shortcuts ( >+ shortcut_name varchar(80) NOT NULL, >+ shortcut_keys varchar(80) NOT NULL, >+ PRIMARY KEY (shortcut_name) >+ ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;| >+ ); >+ } >+ $dbh->do(q| >+ INSERT IGNORE INTO keyboard_shortcuts (shortcut_name, shortcut_keys) VALUES >+ ("insert_copyright","Alt-C"), >+ ("insert_copyright_sound","Alt-P"), >+ ("insert_delimiter","Ctrl-D"), >+ ("subfield_help","Ctrl-H"), >+ ("link_authorities","Shift-Ctrl-L"), >+ ("delete_field","Ctrl-X"), >+ ("delete_subfield","Shift-Ctrl-X"), >+ ("new_line","Enter"), >+ ("line_break","Shift-Enter"), >+ ("next_position","Tab"), >+ ("prev_position","Shift-Tab") >+ ;| >+ ); >+ $dbh->do(q| >+ INSERT IGNORE permissions (module_bit, code, description) >+ VALUES >+ (3,'manage_keyboard_shortcuts','Manage keyboard shortcuts for advanced cataloging editor') >+ ;| >+ ); >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug XXXXX - Add keyboard_shortcuts table)\n"; >+} >diff --git a/installer/data/mysql/atomicupdate/add_keyboard_shortcuts.perl b/installer/data/mysql/atomicupdate/add_keyboard_shortcuts.perl >deleted file mode 100644 >index a90d5a8aa7..0000000000 >--- a/installer/data/mysql/atomicupdate/add_keyboard_shortcuts.perl >+++ /dev/null >@@ -1,30 +0,0 @@ >-$DBversion = 'XXX'; >-if( CheckVersion( $DBversion ) ) { >- unless ( TableExists( 'keyboard_shortcuts' ) ) { >- $dbh->do(q| >- CREATE TABLE keyboard_shortcuts ( >- shortcut_name varchar(80) NOT NULL, >- shortcut_keys varchar(80) NOT NULL, >- shortcut_desc varchar(200) NOT NULL, >- PRIMARY KEY (shortcut_name) >- ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;| >- ); >- } >- $dbh->do(q| >- INSERT IGNORE INTO keyboard_shortcuts (shortcut_name, shortcut_keys, shortcut_desc) VALUES >- ("insert_copyright","Alt-C","Insert copyright symbol (©)"), >- ("insert_copyright_sound","Alt-P","Insert copyright symbol (â) (sound recordings)"), >- ("insert_delimiter","Ctrl-D","Insert delimiter (â¡)"), >- ("subfield_help","Ctrl-H","Get help on current subfield"), >- ("link_authorities","Shift-Ctrl-L","Link field to authorities"), >- ("delete_field","Ctrl-X","Delete current field"), >- ("delete_subfield","Shift-Ctrl-X","Delete current subfield"), >- ("new_line","Enter","New field on next line"), >- ("line_break","Shift-Enter","Insert line break"), >- ("next_position","Tab","Move to next position"), >- ("prev_position","Shift-Tab","Move to previous position") >- ;| >- ); >- SetVersion( $DBversion ); >- print "Upgrade to $DBversion done (Bug XXXXX - Add keyboard_shortcuts table)\n"; >-} >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 00fd133556..ec8626e759 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -4332,7 +4332,6 @@ DROP TABLE IF EXISTS `keyboard_shortcuts`; > CREATE TABLE keyboard_shortcuts ( > shortcut_name varchar(80) NOT NULL, > shortcut_keys varchar(80) NOT NULL, >-shortcut_desc varchar(200) NOT NULL, > PRIMARY KEY (shortcut_name) > ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; > >diff --git a/installer/data/mysql/en/mandatory/keyboard_shortcuts.sql b/installer/data/mysql/mandatory/keyboard_shortcuts.sql >similarity index 52% >rename from installer/data/mysql/en/mandatory/keyboard_shortcuts.sql >rename to installer/data/mysql/mandatory/keyboard_shortcuts.sql >index b7e30d3b73..b7fb58a3f4 100644 >--- a/installer/data/mysql/en/mandatory/keyboard_shortcuts.sql >+++ b/installer/data/mysql/mandatory/keyboard_shortcuts.sql >@@ -21,15 +21,15 @@ > -- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > -- keyboard shortcuts >-INSERT INTO keyboard_shortcuts (shortcut_name, shortcut_keys, shortcut_desc) VALUES >- ("insert_copyright","Alt-C","Insert copyright symbol (©)"), >- ("insert_copyright_sound","Alt-P","Insert copyright symbol (â) (sound recordings)"), >- ("insert_delimiter","Ctrl-D","Insert delimiter (â¡)"), >- ("subfield_help","Ctrl-H","Get help on current subfield"), >- ("link_authorities","Shift-Ctrl-L","Link field to authorities"), >- ("delete_field","Ctrl-X","Delete current field"), >- ("delete_subfield","Shift-Ctrl-X","Delete current subfield"), >- ("new_line","Enter","New field on next line"), >- ("line_break","Shift-Enter","Insert line break"), >- ("next_position","Tab","Move to next position"), >- ("prev_position","Shift-Tab","Move to previous position"); >+INSERT INTO keyboard_shortcuts (shortcut_name, shortcut_keys) VALUES >+ ("insert_copyright","Alt-C"), >+ ("insert_copyright_sound","Alt-P"), >+ ("insert_delimiter","Ctrl-D"), >+ ("subfield_help","Ctrl-H"), >+ ("link_authorities","Shift-Ctrl-L"), >+ ("delete_field","Ctrl-X"), >+ ("delete_subfield","Shift-Ctrl-X"), >+ ("new_line","Enter"), >+ ("line_break","Shift-Enter"), >+ ("next_position","Tab"), >+ ("prev_position","Shift-Tab"); >diff --git a/installer/data/mysql/userpermissions.sql b/installer/data/mysql/userpermissions.sql >index 9679c69f5b..911b81fab6 100644 >--- a/installer/data/mysql/userpermissions.sql >+++ b/installer/data/mysql/userpermissions.sql >@@ -32,6 +32,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES > ( 3, 'manage_usage_stats', 'Manage usage statistics settings'), > ( 3, 'manage_mana', 'Manage Mana KB content sharing'), > ( 3, 'manage_additional_fields', 'Add, edit, or delete additional custom fields for baskets or subscriptions (also requires order_manage or edit_subscription permissions)'), >+ ( 3, 'manage_keyboard_shortcuts', 'Manage keyboard shortcuts for the advanced cataloging editor'), > ( 4, 'edit_borrowers', 'Add, modify and view patron information'), > ( 4, 'view_borrower_infos_from_any_libraries', 'View patron infos from any libraries'), > ( 6, 'place_holds', 'Place holds for patrons'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >index 1677280097..f76f853555 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >@@ -138,6 +138,9 @@ > [% IF ( CAN_user_parameters_manage_additional_fields ) %] > <li><a href="/cgi-bin/koha/admin/additional-fields.pl">Additional fields</a></li> > [% END %] >+ [% IF ( CAN_user_parameters_manage_keyboard_shortcuts ) %] >+ <li><a href="/cgi-bin/koha/admin/adveditorshortcuts.pl">Keyboard shortcuts</a></li> >+ [% END %] > </ul> > [% END %] > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/keyboard_shortcuts.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/keyboard_shortcuts.inc >new file mode 100644 >index 0000000000..e04e4e79c6 >--- /dev/null >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/keyboard_shortcuts.inc >@@ -0,0 +1,15 @@ >+[%- BLOCK keyboard_shortcut_descriptions -%] >+ [% SWITCH shortcut_name %] >+ [%- CASE 'insert_copyright' -%]<span>Insert copyright symbol (©)</span> >+ [%- CASE 'insert_copyright_sound' -%]<span>Insert copyright symbol (â) (sound recordings)</span> >+ [%- CASE 'insert_delimiter' -%]<span>Insert delimiter (â¡)</span> >+ [%- CASE 'subfield_help' -%]<span>Get help on current subfield</span> >+ [%- CASE 'link_authorities' -%]<span>Link field to authorities</span> >+ [%- CASE 'delete_field' -%]<span>Delete current field</span> >+ [%- CASE 'delete_subfield' -%]<span>Delete current subfield</span> >+ [%- CASE 'new_line' -%]<span>New field on next line</span> >+ [%- CASE 'line_break' -%]<span>Insert line break</span> >+ [%- CASE 'next_position' -%]<span>Move to next position</span> >+ [%- CASE 'prev_position' -%]<span>Move to previous position</span> >+ [%- END -%] >+[%- END -%] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >index 0e40101085..d149cdeb61 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >@@ -241,6 +241,11 @@ > Manage Mana KB content sharing > </span> > <span class="permissioncode">([% name | html %])</span> >+ [%- CASE 'manage_keyboard_shortcuts' -%] >+ <span class="sub_permission manage_keyboard_shortcuts_subpermission"> >+ Manage keyboard shortcuts for the advanced cataloging editor >+ </span> >+ <span class="permissioncode">([% name | html %])</span> > [%- CASE 'edit_borrowers' -%] > <span class="sub_permission edit_borrowers_subpermission"> > Add, modify and view patron information >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >index 60c0f572f0..2352bc87f4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >@@ -211,6 +211,10 @@ > <dt><a href="/cgi-bin/koha/admin/additional-fields.pl">Additional fields</a></dt> > <dd>Add additional fields to certain tables</dd> > [% END %] >+ [% IF ( CAN_user_parameters_manage_keyboard_shortcuts ) %] >+ <dt><a href="/cgi-bin/koha/admin/adveditorshortcuts.pl">Keyboard shortcuts</a></dt> >+ <dd>Define which keys trigger actions in the advanced cataloging editor</dd> >+ [% END %] > </dl> > [% END %] > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/adveditorshortcuts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/adveditorshortcuts.tt >similarity index 70% >rename from koha-tmpl/intranet-tmpl/prog/en/modules/tools/adveditorshortcuts.tt >rename to koha-tmpl/intranet-tmpl/prog/en/modules/admin/adveditorshortcuts.tt >index abbc4ac37b..730ed50b3e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/adveditorshortcuts.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/adveditorshortcuts.tt >@@ -2,17 +2,18 @@ > [% USE Asset %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >-<title>Koha › Tools › Advanced editor shortcuts</title> >+<title>Koha › Administration › Advanced editor shortcuts</title> > [% INCLUDE 'doc-head-close.inc' %] > </head> >-<body id="adveditor_shortcuts" class="tools"> >+<body id="adveditor_shortcuts" class="admin"> > [% INCLUDE 'header.inc' %] >- [% INCLUDE 'cat-search.inc' %] >+ [% INCLUDE 'prefs-admin-search.inc' %] >+ [% PROCESS 'keyboard_shortcuts.inc' %] > > <div id="breadcrumbs"> > <a href="/cgi-bin/koha/mainpage.pl">Home</a> › >- <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> › >- <a href="/cgi-bin/koha/tools/adveditorshortcuts.pl">Advanced editor shortcuts</a> >+ <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › >+ <a href="/cgi-bin/koha/admin/adveditorshortcuts.pl">Advanced editor shortcuts</a> > </div> > > <div class="main container-fluid"> >@@ -25,11 +26,12 @@ > <li>Control key is "Ctrl"</li> > <li>Alt key is "Alt"</li> > <li>Shift is "Shift"</li> >- <li>If combing multiple keys they must be in specified order: Shift-Cmd-Ctrl-Alt</li> >+ <li>If combining multiple keys they must be in specified order: Shift-Cmd-Ctrl-Alt</li> > <li><a href="https://codemirror.net/doc/manual.html#keymaps">More documentation on defining key maps</a></li> > </ul> > >- <form id="adveditor_shortcuts" method="post" action="/cgi-bin/koha/tools/adveditorshortcuts.pl"> >+ <form id="adveditor_shortcuts" method="post" action="/cgi-bin/koha/admin/adveditorshortcuts.pl"> >+ <fieldset> > <input type=hidden name="op" value="save" /> > > <table id="adv_editor_keyboard_shortcuts"> >@@ -40,7 +42,7 @@ > <tbody> > [% FOREACH shortcut IN shortcuts %] > <tr> >- <td><label for="shortcut_keys">[% shortcut.shortcut_desc | html %]</label></td> >+ <td><label for="shortcut_keys">[% PROCESS keyboard_shortcut_descriptions shortcut_name=shortcut.shortcut_name %]</label></td> > <td> > <input type="hidden" name="shortcut_name" value="[% shortcut.shortcut_name | html %]"> > <input type="text" name="shortcut_keys" value="[% shortcut.shortcut_keys | html %]"> >@@ -48,7 +50,8 @@ > </tr> > [% END %] > </table> >- <input type="submit" value="Save shortcuts"> >+ </fieldset> >+ </fieldset class="action"><input type="submit" value="Save shortcuts"></fieldset> > </form> > > </main> >@@ -56,7 +59,7 @@ > > <div class="col-sm-2 col-sm-pull-10"> > <aside> >- [% INCLUDE 'tools-menu.inc' %] >+ [% INCLUDE 'admin-menu.inc' %] > </aside> > </div> <!-- /.col-sm-2.col-sm-pull-10 --> > </div> <!-- /.row --> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt >index 90575307a5..fb0011994f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt >@@ -16,6 +16,7 @@ > </div> > > [% INCLUDE 'header.inc' %] >+[% PROCESS 'keyboard_shortcuts.inc' %] > > <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/cataloguing/addbooks.pl">Cataloging</a> › Editor</div> > >@@ -268,7 +269,7 @@ > </div> > > <div id="shortcuts-contents" style="display: none"> >-<a id="redefine_shortcuts" href="/cgi-bin/koha/tools/adveditorshortcuts.pl">Redefine shortcuts</a> >+<a id="redefine_shortcuts" href="/cgi-bin/koha/admin/adveditorshortcuts.pl">Redefine shortcuts</a> > <table class="table table-condensed"> > <thead> > <tr> >@@ -280,7 +281,7 @@ > [% FOREACH shortcut IN shortcuts %] > <tr> > <td>[% shortcut.shortcut_keys | html %]</td> >- <td>[% shortcut.shortcut_desc | html %]</td> >+ <td>[% PROCESS keyboard_shortcut_descriptions shortcut_name=shortcut.shortcut_name %]</td> > </tr> > [% END %] > <tr> >diff --git a/t/db_dependent/Koha/KeyboardShortcuts.t b/t/db_dependent/Koha/KeyboardShortcuts.t >new file mode 100644 >index 0000000000..6dd77e09de >--- /dev/null >+++ b/t/db_dependent/Koha/KeyboardShortcuts.t >@@ -0,0 +1,52 @@ >+#!/usr/bin/perl >+ >+# Copyright 2019 Koha Development team >+# >+# This file is part of Koha >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+use Test::More tests => 4; >+ >+use Koha::Database; >+ >+use t::lib::TestBuilder; >+ >+BEGIN { >+ use_ok('Koha::KeyboardShortcuts'); >+} >+ >+my $schema = Koha::Database->new->schema; >+$schema->storage->txn_begin; >+ >+my $builder = t::lib::TestBuilder->new; >+my $nb_of_shortcuts = Koha::KeyboardShortcuts->search->count; >+ >+my $shortcut_hash = { >+ shortcut_name => 'this_cut', >+ shortcut_keys => 'Ctrl-D', >+ shortcut_desc => 'DOES_THE_THING' >+}; >+ >+my $new_shortcut = Koha::KeyboardShortcut->new($shortcut_hash)->store; >+is( Koha::KeyboardShortcuts->count, $nb_of_shortcuts + 1, 'Adding a new shortcut increases count'); >+ >+my $found_shortcut = Koha::KeyboardShortcuts->find( "this_cut" ); >+is_deeply( $found_shortcut->unblessed, $shortcut_hash, 'We find the right object'); >+ >+$found_shortcut->delete; >+is( Koha::KeyboardShortcuts->count, $nb_of_shortcuts, 'Deleting a new shortcut works'); >+ >+$schema->storage->txn_rollback; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21411
:
79408
|
79409
|
85365
|
85366
|
85397
|
85398
|
86012
|
86013
|
86014
|
86018
|
86019
|
86020
|
88465
|
88466
|
88467
|
88468
|
89119
|
89179
|
89416
|
89417
| 89418 |
89419
|
89420
|
89421