Attachment 89451 Details for Bug 18928 – Bug 18928: Remove '(not set)'

[patch] Bug 18928: Remove '(not set)'

Bug-18928-Remove-not-set.patch (text/plain), 1.70 KB, created by Liz Rea on 2019-05-07 15:11:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2019-05-07 15:11:18 UTC

Size: 1.70 KB

patch

obsolete

>From 61e6afd62797d7d9438a2a3a8d4e5db744ca0771 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 6 May 2019 12:10:58 -0500
>Subject: [PATCH] Bug 18928: Remove '(not set)'
>
>The "(not set)" part must be removed IMO, I am not sure I understand its goal.
>Now that we have 1 entry per rule (and not 1 DB row for the whole "Default
>checkout, hold and return policy for Centerville" table), it will be harder
>to handle it correctly. Not impossible, but if not really needed I would prefer
>to just remove it. If a rule is not set, the cell is empty or the dropdown list
>displays the option "Not set", which seems to correct the problem.
>
>Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 60225e8ee6..bc29c255c8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -409,7 +409,7 @@
>                     <th>Actions</th>
>                 </tr>
>                 <tr>
>-                    <td><em>Defaults[% UNLESS ( default_rules ) %] (not set)[% END %]</em></td>
>+                    <td><em>Defaults</em></td>
>                     <td>
>                         [% SET patron_maxissueqty = CirculationRules.Search( current_branch, undef, undef, 'patron_maxissueqty' ) %]
>                         <input type="text" name="patron_maxissueqty" size="3" value="[% patron_maxissueqty | html %]"/>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18928: 65241 | 65242 | 71005 | 71006 | 81096 | 81097 | 81098 | 81099 | 82933 | 82934 | 82935 | 82936 | 85487 | 85488 | 85489 | 85490 | 85491 | 86134 | 86135 | 86136 | 86137 | 86138 | 86139 | 88659 | 89017 | 89018 | 89019 | 89020 | 89021 | 89022 | 89023 | 89024 | 89333 | 89334 | 89336 | 89338 | 89339 | 89340 | 89341 | 89342 | 89343 | 89344 | 89345 | 89346 | 89347 | 89348 | 89349 | 89377 | 89402 | 89427 | 89428 | 89429 | 89430 | 89431 | 89432 | 89433 | 89434 | 89435 | 89436 | 89437 | 89438 | 89440 | 89441 | 89442 | 89443 | 89444 | 89445 | 89446 | 89447 | 89448 | 89449 | 89450 | 89451 | 89628 | 89629 | 89630 | 89631 | 89632 | 89633 | 89634 | 89635 | 89636 | 89637 | 89638 | 90501 | 91082 | 91083 | 91084 | 91085 | 91086 | 91087 | 91088 | 91089 | 91090 | 91091 | 91092 | 91093 | 91094