Bugzilla – Attachment 89487 Details for
Bug 21658
Renew requests fail if a fee attached
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21658 Define string to avoid run time warnings
Bug-21658-Define-string-to-avoid-run-time-warnings.patch (text/plain), 1.16 KB, created by
Liz Rea
on 2019-05-08 23:13:20 UTC
(
hide
)
Description:
Bug 21658 Define string to avoid run time warnings
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2019-05-08 23:13:20 UTC
Size:
1.16 KB
patch
obsolete
>From c7ac20e915b9d5df106482f9f01b269d7c272a2b Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 25 Oct 2018 10:06:43 +0100 >Subject: [PATCH] Bug 21658 Define string to avoid run time warnings > >In addition to an explicit error a renewal may be >rejected because a fee is due and has not yet been flagged >as paid. In this case define the error message as empty string >to avoid runtime errors in the regexes performed >on the standard error messages > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> >--- > C4/SIP/ILS/Transaction/Renew.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/SIP/ILS/Transaction/Renew.pm b/C4/SIP/ILS/Transaction/Renew.pm >index af96f93901..229b3a2c04 100644 >--- a/C4/SIP/ILS/Transaction/Renew.pm >+++ b/C4/SIP/ILS/Transaction/Renew.pm >@@ -40,6 +40,8 @@ sub do_renew_for { > $self->{fee_amount} = sprintf '%.2f',$fee; > if ($self->{fee_ack} eq 'N') { > $renewokay = 0; >+ $renewerror = q{}; # define error string to avoid runtime warnings >+ # in regexes below > } > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21658
:
81126
|
81127
|
81128
| 89487 |
89488