Bugzilla – Attachment 89495 Details for
Bug 22610
SIP Payment Types should be moved out of accountype
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22610: (follow-up) Correction to accounts tests
Bug-22610-follow-up-Correction-to-accounts-tests.patch (text/plain), 1.96 KB, created by
Martin Renvoize (ashimema)
on 2019-05-09 10:37:41 UTC
(
hide
)
Description:
Bug 22610: (follow-up) Correction to accounts tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-05-09 10:37:41 UTC
Size:
1.96 KB
patch
obsolete
>From aa88d2c476f87add3003bb43320258f239fc1681 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 9 May 2019 09:37:01 +0100 >Subject: [PATCH] Bug 22610: (follow-up) Correction to accounts tests > >--- > t/db_dependent/Koha/Account.t | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/t/db_dependent/Koha/Account.t b/t/db_dependent/Koha/Account.t >index d295b340a2..adc046372a 100755 >--- a/t/db_dependent/Koha/Account.t >+++ b/t/db_dependent/Koha/Account.t >@@ -206,14 +206,12 @@ subtest 'add_credit() tests' => sub { > # Enable logs > t::lib::Mocks::mock_preference( 'FinesLog', 1 ); > >- my $sip_code = "1"; > my $line_2 = $account->add_credit( > { amount => 37, > description => 'Payment of 37', > library_id => $patron->branchcode, > note => 'not really important', > user_id => $patron->id, >- sip => $sip_code, > interface => 'commandline' > } > ); >@@ -221,7 +219,7 @@ subtest 'add_credit() tests' => sub { > is( $account->balance, -62, 'Patron has a balance of -25' ); > is( $schema->resultset('ActionLog')->count(), $action_logs + 1, 'Log was added' ); > is( $schema->resultset('Statistic')->count(), $statistics + 2, 'Action added to statistics' ); >- is( $line_2->accounttype, $Koha::Account::account_type_credit->{'payment'} . $sip_code, 'Account type is correctly set' ); >+ is( $line_2->accounttype, $Koha::Account::account_type_credit->{'payment'}, 'Account type is correctly set' ); > > # offsets have the credit_id set to accountlines_id, and debit_id is undef > my $offset_1 = Koha::Account::Offsets->search({ credit_id => $line_1->id })->next; >@@ -332,7 +330,6 @@ subtest 'add_debit() tests' => sub { > # Enable logs > t::lib::Mocks::mock_preference( 'FinesLog', 1 ); > >- my $sip_code = "1"; > my $line_2 = $account->add_debit( > { > amount => 37, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22610
:
88619
|
88620
|
89460
|
89461
|
89470
|
89471
|
89492
|
89493
|
89494
|
89495
|
89496
|
89498
|
89499
|
89500
|
89501
|
89502
|
89503
|
91638
|
91639
|
91640
|
91641
|
91642
|
91643