Bugzilla – Attachment 8950 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests
0001-Bug-6679-SIGNED-OFF-members-dir-now-passes-perlcriti.patch (text/plain), 2.29 KB, created by
Jonathan Druart
on 2012-04-06 12:42:21 UTC
(
hide
)
Description:
Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-04-06 12:42:21 UTC
Size:
2.29 KB
patch
obsolete
>From d926db153dd6e8b226c63e0d7af5fa5015e6ad32 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Thu, 5 Apr 2012 14:43:20 +1200 >Subject: [PATCH 1/1] Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic > tests > >signed-off-by Jonathan Druart <jonathan.druart@biblibre.com> >--- > members/member-picupload.pl | 8 ++++---- > members/member.pl | 3 ++- > t/00-testcritic.t | 2 +- > 3 files changed, 7 insertions(+), 6 deletions(-) > >diff --git a/members/member-picupload.pl b/members/member-picupload.pl >index 7e5aad8..101a54f 100755 >--- a/members/member-picupload.pl >+++ b/members/member-picupload.pl >@@ -59,13 +59,13 @@ if ($photo){ > > my $filename=$borrowernumber.'.jpg'; > my $upload_filehandle = $input->upload("photo"); >- open UPLOADFILE, ">$upload_dir/$filename"; >- binmode UPLOADFILE; >+ open (my $upload_fh, '>', "$upload_dir/$filename"); >+ binmode $upload_fh; > while ( <$upload_filehandle> ) > { >- print UPLOADFILE; >+ print $upload_fh; > } >- close UPLOADFILE; >+ close $upload_fh; > } > else { > $template->param( >diff --git a/members/member.pl b/members/member.pl >index 9b793f4..bef3323 100755 >--- a/members/member.pl >+++ b/members/member.pl >@@ -58,7 +58,8 @@ my $branches = GetBranches; > my @branchloop; > > foreach (sort { $branches->{$a}->{branchname} cmp $branches->{$b}->{branchname} } keys %$branches) { >- my $selected = 1 if $branches->{$_}->{branchcode} eq $$patron{branchcode}; >+ my $selected; >+ $selected = 1 if $branches->{$_}->{branchcode} eq $$patron{branchcode}; > my %row = ( value => $_, > selected => $selected, > branchname => $branches->{$_}->{branchname}, >diff --git a/t/00-testcritic.t b/t/00-testcritic.t >index c28a2dc..daa2aa6 100755 >--- a/t/00-testcritic.t >+++ b/t/00-testcritic.t >@@ -17,7 +17,7 @@ labels members misc offline_circ opac patroncards reports reserve reviews rotati > serials sms suggestion t tags test tools virtualshelves Koha); > > my @dirs = qw( acqui admin authorities basket catalogue cataloguing circ debian errors labels >- offline_circ reserve reviews rotating_collections serials sms virtualshelves Koha); >+ members offline_circ reserve reviews rotating_collections serials sms virtualshelves Koha misc); > > if ( not $ENV{TEST_QA} ) { > my $msg = 'Author test. Set $ENV{TEST_QA} to a true value to run'; >-- >1.7.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208