Attachment 89520 Details for Bug 22657 – Bug 22657: (QA follow-up) Restore previous version of regex

[patch] Bug 22657: (QA follow-up) Restore previous version of regex

Bug-22657-QA-follow-up-Restore-previous-version-of.patch (text/plain), 987 bytes, created by Owen Leonard on 2019-05-09 18:04:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-05-09 18:04:58 UTC

Size: 987 bytes

patch

obsolete

>From 7291dc9b756bba6e8c7cc66c5402f14612d37b25 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 9 May 2019 17:52:26 +0000
>Subject: [PATCH] Bug 22657: (QA follow-up) Restore previous version of regex
>
>This patch restores the previous version of the regular expression which
>parses the OPACSuggestionMandatoryFields system preference value.
>---
> opac/opac-suggestions.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl
>index 1d11d75..8f792cd 100755
>--- a/opac/opac-suggestions.pl
>+++ b/opac/opac-suggestions.pl
>@@ -212,7 +212,7 @@ my @mandatoryfields;
> {
>     last unless ($op eq 'add');
>     my $fldsreq_sp = C4::Context->preference("OPACSuggestionMandatoryFields") || 'title';
>-    @mandatoryfields = split( ",", $fldsreq_sp );
>+    @mandatoryfields = sort split(/\s*\,\s*/, $fldsreq_sp);
>     foreach (@mandatoryfields) {
>         $template->param( $_."_required" => 1);
>     }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 22657: 87526 | 87939 | 88132 | 89504 | 89520 | 89525 | 89526