Attachment 89526 Details for Bug 22657 – Bug 22657: (QA follow-up) Restore previous version of regex

[patch] Bug 22657: (QA follow-up) Restore previous version of regex

Bug-22657-QA-follow-up-Restore-previous-version-of.patch (text/plain), 1.07 KB, created by Marcel de Rooy on 2019-05-10 07:34:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-05-10 07:34:06 UTC

Size: 1.07 KB

patch

obsolete

>From 64dc7acc93a824bf3ecc97a50386ebce41a48ddb Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 9 May 2019 17:52:26 +0000
>Subject: [PATCH] Bug 22657: (QA follow-up) Restore previous version of regex
>Content-Type: text/plain; charset=utf-8
>
>This patch restores the previous version of the regular expression which
>parses the OPACSuggestionMandatoryFields system preference value.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> opac/opac-suggestions.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl
>index 1d11d75cf4..8f792cd98f 100755
>--- a/opac/opac-suggestions.pl
>+++ b/opac/opac-suggestions.pl
>@@ -212,7 +212,7 @@ my @mandatoryfields;
> {
>     last unless ($op eq 'add');
>     my $fldsreq_sp = C4::Context->preference("OPACSuggestionMandatoryFields") || 'title';
>-    @mandatoryfields = split( ",", $fldsreq_sp );
>+    @mandatoryfields = sort split(/\s*\,\s*/, $fldsreq_sp);
>     foreach (@mandatoryfields) {
>         $template->param( $_."_required" => 1);
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22657: 87526 | 87939 | 88132 | 89504 | 89520 | 89525 | 89526