Bugzilla – Attachment 89547 Details for
Bug 22433
Add debug statements to understand why SIP/Transaction.t is failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22433: Add debug statement to Transaction.t
Bug-22433-Add-debug-statement-to-Transactiont.patch (text/plain), 1.53 KB, created by
Martin Renvoize (ashimema)
on 2019-05-10 13:14:58 UTC
(
hide
)
Description:
Bug 22433: Add debug statement to Transaction.t
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-05-10 13:14:58 UTC
Size:
1.53 KB
patch
obsolete
>From 0a82da56357025994fa40381f159b20bb06d48b8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 9 May 2019 13:04:38 -0500 >Subject: [PATCH] Bug 22433: Add debug statement to Transaction.t > >Hard to know what's going on here without more info. Adding this output >may help to investigate more. > >Test plan: >Make sure the tests still pass > >If it fails, please paste the output!! > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/SIP/Transaction.t | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t >index af3fa0aeb8..0197c9c663 100755 >--- a/t/db_dependent/SIP/Transaction.t >+++ b/t/db_dependent/SIP/Transaction.t >@@ -86,8 +86,9 @@ subtest fill_holds_at_checkout => sub { > is( ref $transaction, "C4::SIP::ILS::Transaction::Checkout", "New transaction created" ); > is( $transaction->patron( $sip_patron ), $sip_patron, "Patron assigned to transaction" ); > is( $transaction->item( $sip_item ), $sip_item, "Item assigned to transaction" ); >- $transaction->do_checkout(); >- is( $bib->holds->count(), 1, "Bib has 1 holds remaining"); >+ my $checkout = $transaction->do_checkout(); >+ use Data::Printer colored => 1; # Temporary debug statement >+ is( $bib->holds->count(), 1, "Bib has 1 holds remaining") or diag p $checkout; > > t::lib::Mocks::mock_preference('itemBarcodeInputFilter', 'whitespace'); > $sip_item = C4::SIP::ILS::Item->new( ' barcode 4 test '); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22433
:
89521
| 89547 |
89564