Bugzilla – Attachment 89646 Details for
Bug 22892
Warning when reindexing without parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22892: Remove warning from rebuild_es if --processes not passed
Bug-22892-Remove-warning-from-rebuildes-if---proce.patch (text/plain), 1.24 KB, created by
Jonathan Druart
on 2019-05-13 00:49:35 UTC
(
hide
)
Description:
Bug 22892: Remove warning from rebuild_es if --processes not passed
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-05-13 00:49:35 UTC
Size:
1.24 KB
patch
obsolete
>From 248839479ea36ef243197bfc248bc6fe8b8a785d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sun, 12 May 2019 19:46:58 -0500 >Subject: [PATCH] Bug 22892: Remove warning from rebuild_es if --processes not > passed > >Use of uninitialized value $processes in numeric lt (<) at >misc/search_tools/rebuild_elasticsearch.pl line 199. > >We want the number of processes to be set to 1 by default, and then >assign it to $slice_count > >Test plan: >Run the script with and without --processes and confirm that the warning >went away. >--- > misc/search_tools/rebuild_elasticsearch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/search_tools/rebuild_elasticsearch.pl b/misc/search_tools/rebuild_elasticsearch.pl >index fa88a3cc96..1199b63922 100755 >--- a/misc/search_tools/rebuild_elasticsearch.pl >+++ b/misc/search_tools/rebuild_elasticsearch.pl >@@ -138,7 +138,7 @@ _verify_index_state($Koha::SearchEngine::Elasticsearch::BIBLIOS_INDEX, $delete) > _verify_index_state($Koha::SearchEngine::Elasticsearch::AUTHORITIES_INDEX, $delete) if ($index_authorities); > > my $slice_index = 0; >-my $slice_count = $processes // 1; >+my $slice_count = ( $processes //= 1 ); > my %iterator_options; > > if ($slice_count > 1) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22892
:
89646
|
89721