Bugzilla – Attachment 89655 Details for
Bug 22863
Item replacement cost with tax
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Revert "Bug 22478: (QA follow-up) Update tests to check for any script tags"
Revert-Bug-22478-QA-follow-up-Update-tests-to-chec.patch (text/plain), 2.03 KB, created by
Martin Renvoize (ashimema)
on 2019-05-13 13:26:06 UTC
(
hide
)
Description:
Revert "Bug 22478: (QA follow-up) Update tests to check for any script tags"
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-05-13 13:26:06 UTC
Size:
2.03 KB
patch
obsolete
>From 1dd35e626c1446c8613a53c4cc7b8cb62f6e2228 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 2 May 2019 20:49:37 -0400 >Subject: [PATCH] Revert "Bug 22478: (QA follow-up) Update tests to check for > any script tags" > >This reverts commit d9b3b90849fd95d296b73b330c4e32ff018c81a5. > >https://bugs.koha-community.org/show_bug.cgi?id=22836 >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >https://bugs.koha-community.org/show_bug.cgi?id=22863 >--- > t/db_dependent/selenium/regressions.t | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index 88bfb1dbfc..ac24963bde 100644 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -188,7 +188,7 @@ subtest 'Display circulation table correctly' => sub { > }; > > subtest 'XSS vulnerabilities in pagination' => sub { >- plan tests => 4; >+ plan tests => 3; > > my $patron = $builder->build_object({ class => 'Koha::Patrons' }); > for ( 1 .. 30 ) { # We want the pagination to be displayed >@@ -228,8 +228,7 @@ subtest 'XSS vulnerabilities in pagination' => sub { > is( $alert_text, undef, 'No alert box displayed, even if evil intent' ); > > my $second_page = $driver->find_element('//div[@class="pages"]/span[@class="currentPage"]/following-sibling::a'); >- unlike( $second_page->get_attribute('href'), qr{%22%3E%3Cscript%3Ealert%28%27booh%21%27%29%3C%2Fscript%3E}, 'The second page link should not contain any script tags (escaped or otherwise)' ); >- unlike( $second_page->get_attribute('href'), qr{"<script>alert('booh!')</script>}, 'The second page link should not contain any script tags (escaped or otherwise)' ); >+ like( $second_page->get_attribute('href'), qr{category=1%22%3E%3Cscript%3Ealert%28%27booh%21%27%29%3C%2Fscript%3E}, 'The second patch should displayed the variables and attributes correctly URI escaped' ); > > push @cleanup, $patron, $patron->category, $patron->library; > }; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22863
:
89655
|
89656
|
89657