Bugzilla – Attachment 89665 Details for
Bug 13640
Holds To Pull List includes items unreserveable items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13640: Do not display unreserveable items on the Holds to pull screen
Bug-13640-Do-not-display-unreserveable-items-on-th.patch (text/plain), 1.81 KB, created by
Jonathan Druart
on 2019-05-13 15:02:50 UTC
(
hide
)
Description:
Bug 13640: Do not display unreserveable items on the Holds to pull screen
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-05-13 15:02:50 UTC
Size:
1.81 KB
patch
obsolete
>From 5477795878d5e0cc92941541c11cbca57698d62b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 13 May 2019 09:57:52 -0500 >Subject: [PATCH] Bug 13640: Do not display unreserveable items on the Holds to > pull screen > >We should only display the items that meet the hold policies > >Test plan: >It would be good to have a huge list of holds displayed on the "Holds to >pull" and confirm that the display is now correct. > >One of the possible test plan has been let in a comment on the bug >report: >Bib Record A has 2 items: > >Item Record X (can be placed on hold) >Item Record Y (cannot be placed on hold) > >If you place a bib-level hold on Bib Record A, both Item Record X and >Item Record Y show up as available items in the Holds To Pull List. > >With this patch applied you must not see Y >--- > circ/pendingreserves.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index d0c727413f..56acc2dcce 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -210,6 +210,7 @@ my $strsth = > LEFT JOIN branchtransfers ON items.itemnumber=branchtransfers.itemnumber > LEFT JOIN issues ON items.itemnumber=issues.itemnumber > LEFT JOIN borrowers ON reserves.borrowernumber=borrowers.borrowernumber >+ LEFT JOIN default_branch_item_rules ON items.itype=default_branch_item_rules.itemtype > WHERE > reserves.found IS NULL > $sqldatewhere >@@ -220,6 +221,7 @@ my $strsth = > AND reserves.priority <> 0 > AND reserves.suspend = 0 > AND notforloan = 0 AND itemlost = 0 AND withdrawn = 0 >+ AND default_branch_item_rules.holdallowed != 0 > "; > # GROUP BY reserves.biblionumber allows only items that are not checked out, else multiples occur when > # multiple patrons have a hold on an item >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13640
:
89665
|
90639
|
90871
|
90872