Bugzilla – Attachment 89672 Details for
Bug 22896
Item to be transferred at checkin clears overridden due date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22896: Missing inputs in transfer modal
Bug-22896-Missing-inputs-in-transfer-modal.patch (text/plain), 4.99 KB, created by
Liz Rea
on 2019-05-13 16:22:43 UTC
(
hide
)
Description:
Bug 22896: Missing inputs in transfer modal
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2019-05-13 16:22:43 UTC
Size:
4.99 KB
patch
obsolete
>From e132666e84fbb4de9a6172e9552cf9a91b826a54 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 13 May 2019 15:34:47 +0000 >Subject: [PATCH] Bug 22896: Missing inputs in transfer modal > >This patch restores hidden inputs to save overridden checkin date and other data > >Currently we lose the list of checkouts and several settings when items with transfers are checked in > >To test: >1 - Find an item from another branch >2 - Set a checkin date and click the box for the date to be remembered >3 - Check in the item >4 - Click ok or print, note the checkin date is lost >5 - Apply patch >6 - Repeat >7 - Checkin date remains > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> >--- > .../intranet-tmpl/prog/en/modules/circ/returns.tt | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 294fcb85af..cb2dc07c51 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -221,6 +221,8 @@ > <button type="submit" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button> > <button type="submit" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | html %]&&branchcode=[% TransferWaitingAt | html %]&op=slip"><i class="fa fa-print"></i> Print transfer slip</button> > <button class="btn btn-default deny cancel-transfer" type="submit"><i class="fa fa-times"></i> Cancel transfer</button> >+ <input type="hidden" name="return_date_override" value="[% return_date_override | html %]" /> >+ <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember | html %]" /> > </div> > </form> > </div> >@@ -385,17 +387,7 @@ > </p> > <input type="hidden" name="tobranch" value="[% returnbranch | html %]" /> > <input type="hidden" name="transferitem" value="[% itemnumber | html %]" /> >- <input type="hidden" name="exemptfine" value="[% exemptfine | html %]" /> >- <input type="hidden" name="dropboxmode" value="[% dropboxmode | html %]" /> >- <input type="hidden" name="forgivemanualholdsexpire" value="[% forgivemanualholdsexpire | html %]" /> >- [% FOREACH inputloo IN inputloop %] >- <input type="hidden" name="ri-[% inputloo.counter | html %]" value="[% inputloo.barcode | html %]" /> >- <input type="hidden" name="dd-[% inputloo.counter | html %]" value="[% inputloo.duedate | html %]" /> >- <input type="hidden" name="bn-[% inputloo.counter | html %]" value="[% inputloo.borrowernumber | html %]" /> >- [% END %] > <input type="hidden" name="barcode" value="0" /> >- <input type="hidden" name="return_date_override" value="[% return_date_override | html %]" /> >- <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember | html %]" /> > [% END %] > </div> > <div class="modal-footer"> >@@ -406,6 +398,16 @@ > <button type="submit" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button> > <button type="submit" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | html %]&&branchcode[% returnbranch | html %]&op=slip"><i class="fa fa-print"></i> Print slip</button> > [% END %] >+ <input type="hidden" name="return_date_override" value="[% return_date_override | html %]" /> >+ <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember | html %]" /> >+ <input type="hidden" name="exemptfine" value="[% exemptfine | html %]" /> >+ <input type="hidden" name="dropboxmode" value="[% dropboxmode | html %]" /> >+ <input type="hidden" name="forgivemanualholdsexpire" value="[% forgivemanualholdsexpire | html %]" /> >+ [% FOREACH inputloo IN inputloop %] >+ <input type="hidden" name="ri-[% inputloo.counter | html %]" value="[% inputloo.barcode | html %]" /> >+ <input type="hidden" name="dd-[% inputloo.counter | html %]" value="[% inputloo.duedate | html %]" /> >+ <input type="hidden" name="bn-[% inputloo.counter | html %]" value="[% inputloo.borrowernumber | html %]" /> >+ [% END %] > </div> > </form> > </div> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22896
:
89667
|
89670
|
89671
|
89672
|
89825