Attachment 89792 Details for Bug 22908 – Bug 22908: Add tests

[patch] Bug 22908: Add tests

Bug-22908-Add-tests.patch (text/plain), 1.47 KB, created by Liz Rea on 2019-05-15 17:52:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2019-05-15 17:52:25 UTC

Size: 1.47 KB

patch

obsolete

>From d35ab3e56503e1bee4ab3c47dafe8c38525c1016 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 14 May 2019 12:21:57 -0500
>Subject: [PATCH] Bug 22908: Add tests
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>---
> t/db_dependent/Suggestions.t | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Suggestions.t b/t/db_dependent/Suggestions.t
>index 46d4582006..4c2760e684 100644
>--- a/t/db_dependent/Suggestions.t
>+++ b/t/db_dependent/Suggestions.t
>@@ -18,7 +18,7 @@
> use Modern::Perl;
> 
> use DateTime::Duration;
>-use Test::More tests => 109;
>+use Test::More tests => 110;
> use Test::Warn;
> 
> use t::lib::Mocks;
>@@ -249,6 +249,13 @@ $messages = C4::Letters::GetQueuedMessages({
> });
> is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is email if the borrower has an email');
> 
>+$mod_suggestion4->{manageddate} = 'invalid date!';
>+ModSuggestion($mod_suggestion4);
>+$messages = C4::Letters::GetQueuedMessages({
>+    borrowernumber => $borrowernumber2
>+});
>+is (scalar(@$messages), 1, 'No new letter should have been generated if the update raised an error');
>+
> is( GetSuggestionInfo(), undef, 'GetSuggestionInfo without the suggestion id returns undef' );
> $suggestion = GetSuggestionInfo($my_suggestionid);
> is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfo returns the suggestion id correctly' );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22908: 89765 | 89766 | 89792 | 89793 | 90113 | 90114