Attachment 89876 Details for Bug 22917 – Bug 22917: Fix a typo in an output_pref call

[patch] Bug 22917: Fix a typo in an output_pref call

Bug-22917-Fix-a-typo-in-an-outputpref-call.patch (text/plain), 1.88 KB, created by Jonathan Druart on 2019-05-16 19:08:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-05-16 19:08:11 UTC

Size: 1.88 KB

patch

obsolete

>From 2ee6846d9c93da234413c59adf3c40a244f7c148 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 16 May 2019 16:55:16 +0100
>Subject: [PATCH] Bug 22917: Fix a typo in an output_pref call
>
>Due to a type in a call to output_pref (datenonly vs dateonly) we were
>comparing logactions within a minutes accuracy. Counting the logs for
>the day would be sufficient for the test ;)
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Circulation.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 37ab7a57b7..54b3c78eaa 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -3000,7 +3000,7 @@ subtest 'AddRenewal and AddIssuingCharge tests' => sub {
>     # Check the item out
>     AddIssue( $patron->unblessed, $item->barcode );
>     t::lib::Mocks::mock_preference( 'RenewalLog', 0 );
>-    my $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } );
>+    my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
>     my %params_renewal = (
>         timestamp => { -like => $date . "%" },
>         module => "CIRCULATION",
>@@ -3016,7 +3016,7 @@ subtest 'AddRenewal and AddIssuingCharge tests' => sub {
>     unlike ( $checkouts->next->lastreneweddate, qr/00:00:00/, 'AddRenewal should set the renewal date with the time part');
> 
>     t::lib::Mocks::mock_preference( 'RenewalLog', 1 );
>-    $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } );
>+    $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
>     $old_log_size = Koha::ActionLogs->count( \%params_renewal );
>     AddRenewal( $patron->id, $item->id, $library->id );
>     $new_log_size = Koha::ActionLogs->count( \%params_renewal );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22917: 89797 | 89798 | 89799 | 89853 | 89855 | 89856 | 89857 | 89876 | 89877 | 90018 | 90019 | 90020 | 90021