Attachment 89941 Details for Bug 22947 – Bug 22947: Markup error in OPAC preferences file

[patch] Bug 22947: Markup error in OPAC preferences file

Bug-22947-Markup-error-in-OPAC-preferences-file.patch (text/plain), 2.81 KB, created by Owen Leonard on 2019-05-21 13:43:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-05-21 13:43:29 UTC

Size: 2.81 KB

patch

obsolete

>From 93c07a5db1d65e2e3b7856f34875e2b20d288ba7 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 21 May 2019 13:19:17 +0000
>Subject: [PATCH] Bug 22947: Markup error in OPAC preferences file
>
>This patch corrects a markup error in the OPAC .pref file which can
>cause display problems. The patch also corrects a validator warning by
>changing at <tt> to a <code>.
>
>To reproduce the problem, go to Administration -> Global system
>preferences -> OPAC.
>
>Run the page through the W3C validation service:
>https://validator.w3.org. Either by pasting in the URL for the search
>results (if web accessible) or by viewing source, copying, and pasting
>into "Validate by Direct Input."
>
>This patch addresses two specific errors:
>
> - "Unclosed element code."
> - "The tt element is obsolete. Use CSS instead."
>
>To test, apply the patch and try again to reproduce the validation
>errors. Those errors should no longer be present. There should be no
>visible change to the display.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 8300553..567e622 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -121,7 +121,7 @@ OPAC:
>                   no: "Don't include"
>             - "COinS / OpenURL / Z39.88 in OPAC search results.  <br/>Warning: Enabling this feature will slow OPAC search response times."
>             - "<br/>If you want to display a link to an OpenURL resolver, look at the following system preferences:"
>-            - "<br/><code>OpenURLResolverURL</code>, <code>OPACShowOpenURL</code>, <code>OPACOpenURLItemTypes</code>, <code>OpenURLText<code>, <code>OpenURLImageLocation</code>"
>+            - "<br/><code>OpenURLResolverURL</code>, <code>OPACShowOpenURL</code>, <code>OPACOpenURLItemTypes</code>, <code>OpenURLText</code>, <code>OpenURLImageLocation</code>"
>         -
>             - pref: OPACShowUnusedAuthorities
>               choices:
>@@ -639,7 +639,7 @@ OPAC:
>             - Define custom rules to hide specific items from search and view on the OPAC. How to write these rules is documented on the <a href="http://wiki.koha-community.org/wiki/OpacHiddenItems" target="_blank">Koha wiki</a>.
>         -
>             - pref: OpacHiddenItemsExceptions
>-            - List of borrower categories, separated by |, that can see items otherwise hidden by <tt>OpacHiddenItems</tt>
>+            - List of borrower categories, separated by |, that can see items otherwise hidden by <code>OpacHiddenItems</code>
>         -
>             - pref: OpacAllowPublicListCreation
>               default: 1
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 22947: 89941 | 90087 | 90130