Attachment 89949 Details for Bug 22955 – Bug 22955: Markup error in OPAC lists template

[patch] Bug 22955: Markup error in OPAC lists template

Bug-22955-Markup-error-in-OPAC-lists-template.patch (text/plain), 1.97 KB, created by Owen Leonard on 2019-05-21 17:38:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-05-21 17:38:52 UTC

Size: 1.97 KB

patch

obsolete

>From cda1e4eda9af5bbadaa5f3f74685ae674dd62957 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 21 May 2019 17:14:36 +0000
>Subject: [PATCH] Bug 22955: Markup error in OPAC lists template
>
>This patch makes a minor correction to the template for OPAC lists.
>This correction fixes an error returned by the HTML validator by adding
>an empty "alt" attribute to an image tag.
>
>To reproduce the problem you should have at least one list available in
>the OPAC with one or more items on it. View the contents of that list in
>the OPAC. Run the page through the W3C validation service:
>https://validator.w3.org. Either by pasting in the URL for the search
>results (if web accessible) or by viewing source, copying, and pasting
>into "Validate by Direct Input."
>
>This patch addresses one specific error:
>
> - "An img element must have an alt attribute, except
>    under certain conditions."
>
>To test, apply the patch and try again to reproduce the validation
>error. The error should no longer be present. There should be no
>visible change to the page.
>
>Click "Download list." A modal window should appear with a "Loading"
>message, followed by a form for selecting a download format.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index 10d452d..b837bcd 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -751,7 +751,7 @@
>     <div class="modal-content">
>         <div class="modal-body">
>             <div style="margin:1em;padding:1em;font-size:150%;">
>-                <img src="[% interface | html %]/[% theme | html %]/images/loading.gif" /> Loading
>+                <img src="[% interface | html %]/[% theme | html %]/images/loading.gif" alt="" /> Loading
>             </div>
>         </div>
>     </div>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 22955: 89949 | 90091 | 90131