Attachment 89989 Details for Bug 22445 – Bug 22445: Add new pattern %normalized_isbn%

[patch] Bug 22445: Add new pattern %normalized_isbn%

Bug-22445-Add-new-pattern-normalizedisbn.patch (text/plain), 3.24 KB, created by Jonathan Druart on 2019-05-23 02:41:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-05-23 02:41:24 UTC

Size: 3.24 KB

patch

obsolete

>From 4daeafa4ac1ae1805ea6043f30ea9f9a38577838 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 4 Apr 2019 22:32:20 -0300
>Subject: [PATCH] Bug 22445: Add new pattern %normalized_isbn%
>
>Quite bad to use C4::Koha from Koha::Biblio :-/
>---
> Koha/Biblio.pm                                                    | 5 +++++
> .../prog/en/modules/admin/preferences/enhanced_content.pref       | 2 +-
> t/db_dependent/Koha/Biblios.t                                     | 8 ++++++--
> 3 files changed, 12 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index eff5f58472..7fd0a8d078 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -24,6 +24,7 @@ use List::MoreUtils qw(any);
> use URI;
> use URI::Escape;
> 
>+use C4::Koha;
> use C4::Biblio qw();
> 
> use Koha::Database;
>@@ -672,6 +673,10 @@ sub custom_cover_image_url {
>         my $isbn = $self->biblioitem->isbn;
>         $url =~ s|%isbn%|$isbn|g;
>     }
>+    if ( $url =~ m|%normalized_isbn%| ) {
>+        my $normalized_isbn = C4::Koha::GetNormalizedISBN($self->biblioitem->isbn);
>+        $url =~ s|%normalized_isbn%|$normalized_isbn|g;
>+    }
>     if ( $url =~ m|%issn%| ) {
>         my $issn = $self->biblioitem->issn;
>         $url =~ s|%issn%|$issn|g;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
>index e06ae65b3b..1388269fe8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
>@@ -346,7 +346,7 @@ Enhanced Content:
>             - "Using the following URL:"
>             - pref: CustomCoverImagesURL
>               class: url
>-            - "You can defined it using the following patterns: %isbn%, %issn%."
>+            - "You can define it using the following patterns: %isbn%, %issn%, %normalized_isbn%."
>     HTML5 Media:
>         -
>             - Show a tab with a HTML5 media player for files catalogued in field 856
>diff --git a/t/db_dependent/Koha/Biblios.t b/t/db_dependent/Koha/Biblios.t
>index 2e7ce189e2..177eda81e8 100644
>--- a/t/db_dependent/Koha/Biblios.t
>+++ b/t/db_dependent/Koha/Biblios.t
>@@ -188,11 +188,11 @@ subtest 'can_be_transferred' => sub {
> };
> 
> subtest 'custom_cover_image_url' => sub {
>-    plan tests => 2;
>+    plan tests => 3;
> 
>     t::lib::Mocks::mock_preference( 'CustomCoverImagesURL', 'https://my_url/%isbn%_%issn%.png' );
> 
>-    my $isbn       = 'my_isbn';
>+    my $isbn       = '0553573403 | 9780553573404 (pbk.).png';
>     my $issn       = 'my_issn';
>     my $marc_record = MARC::Record->new;
>     my ( $biblionumber, undef ) = C4::Biblio::AddBiblio($marc_record, '');
>@@ -208,6 +208,10 @@ subtest 'custom_cover_image_url' => sub {
> 
>     t::lib::Mocks::mock_preference( 'CustomCoverImagesURL', 'https://my_url/%024$a%.png' );
>     is( $biblio->custom_cover_image_url, "https://my_url/$marc_024a.png" );
>+
>+    t::lib::Mocks::mock_preference( 'CustomCoverImagesURL', 'https://my_url/%normalized_isbn%.png' );
>+    my $normalized_isbn = C4::Koha::GetNormalizedISBN($isbn);
>+    is( $biblio->custom_cover_image_url, "https://my_url/$normalized_isbn.png" );
> };
> 
> $schema->storage->txn_rollback;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22445: 85925 | 85926 | 85927 | 85928 | 85929 | 85930 | 85931 | 85932 | 85933 | 85934 | 85935 | 85936 | 85937 | 85938 | 86214 | 86726 | 86727 | 87434 | 89973 | 89974 | 89975 | 89976 | 89977 | 89978 | 89979 | 89980 | 89981 | 89982 | 89983 | 89984 | 89985 | 89986 | 89987 | 89988 | 89989 | 89996 | 89997 | 89998 | 89999 | 90000 | 90001 | 90002 | 90003 | 90004 | 90005 | 90006 | 90007 | 90009 | 90010 | 90011 | 90012 | 90013 | 94227 | 94228 | 94229 | 94230 | 94231 | 94232 | 94233 | 94234 | 94235 | 94236 | 94237 | 94238 | 94239 | 94240 | 94241 | 94242 | 94243 | 94244 | 94559 | 94560 | 94561 | 94562 | 94563 | 94564 | 94566 | 94567 | 94568 | 94569 | 94570 | 94571 | 94572 | 94573 | 94574 | 94575 | 94576 | 94577