Attachment 90012 Details for Bug 22445 – Bug 22445: (follow-up) Use CSS to set a max-width for images - Staff client

[patch] Bug 22445: (follow-up) Use CSS to set a max-width for images - Staff client

Bug-22445-follow-up-Use-CSS-to-set-a-max-width-for.patch (text/plain), 3.74 KB, created by Michal Denar on 2019-05-23 08:26:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Denar

Created: 2019-05-23 08:26:02 UTC

Size: 3.74 KB

patch

obsolete

>From d1bea9a1fcaeb0bae611b41e8ce6e29231d26cd2 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 18 Mar 2019 17:44:30 +0000
>Subject: [PATCH] Bug 22445: (follow-up) Use CSS to set a max-width for images
> - Staff client
>
>This patch adds some CSS and markup to staff client templates so that
>custom cover images have a maximum width of 140px (to match the width of
>generated local cover image thumbnails). This prevents oversized images
>from displaying inconsistently compared to images from other services.
>
>This patch also adds a missing </a> to fix display problems.
>
>To test, apply the patch and regenerate the staff client CSS. Post an
>oversized image which corresponds to a record in your catalog.
>
>View the following pages to confirm that the image displays well:
>
> - Catalog search results
> - Bibliographic detail page
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss       | 6 ++++++
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt  | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 2 +-
> 3 files changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 0ac6b70d48..09742e1d5d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -2454,6 +2454,12 @@ li {
>     text-align: center;
> }
> 
>+.custom_cover_image {
>+    img {
>+        max-width: 140px;
>+    }
>+}
>+
> .searchhighlightblob {
>     font-size: 75%;
>     font-style: italic;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 019c4aad15..f103567670 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -143,7 +143,7 @@
>         [% END %]
> 
>         [% IF Koha.Preference('CustomCoverImages') && Koha.Preference('CustomCoverImagesURL') %]
>-            <a href="[% biblio.custom_cover_image_url | url %]"><img alt="Cover image" src="[% biblio.custom_cover_image_url | url %]" />
>+            <a class="custom_cover_image" href="[% biblio.custom_cover_image_url | url %]"><img alt="Cover image" src="[% biblio.custom_cover_image_url | url %]" /></a>
>         [% END %]
>         [% END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index 6008047a74..d1679f3fc6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -396,7 +396,7 @@
>                                                         </a>
>                                                     [% END # /IF AmazonCoverImages %]
>                                                     [% IF Koha.Preference('CustomCoverImages') && Koha.Preference('CustomCoverImagesURL') %]
>-                                                        <a href="[% SEARCH_RESULT.biblio_object.custom_cover_image_url | url %]"><img alt="Cover image" src="[% SEARCH_RESULT.biblio_object.custom_cover_image_url | url %]" />
>+                                                        <a class="custom_cover_image" href="[% SEARCH_RESULT.biblio_object.custom_cover_image_url | url %]"><img alt="Cover image" src="[% SEARCH_RESULT.biblio_object.custom_cover_image_url | url %]" />
>                                                     [% END %]
>                                                 </td>
>                                             [% END # /IF( AmazonCoverImages || LocalCoverImages || AdlibrisEnabled )%]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22445: 85925 | 85926 | 85927 | 85928 | 85929 | 85930 | 85931 | 85932 | 85933 | 85934 | 85935 | 85936 | 85937 | 85938 | 86214 | 86726 | 86727 | 87434 | 89973 | 89974 | 89975 | 89976 | 89977 | 89978 | 89979 | 89980 | 89981 | 89982 | 89983 | 89984 | 89985 | 89986 | 89987 | 89988 | 89989 | 89996 | 89997 | 89998 | 89999 | 90000 | 90001 | 90002 | 90003 | 90004 | 90005 | 90006 | 90007 | 90009 | 90010 | 90011 | 90012 | 90013 | 94227 | 94228 | 94229 | 94230 | 94231 | 94232 | 94233 | 94234 | 94235 | 94236 | 94237 | 94238 | 94239 | 94240 | 94241 | 94242 | 94243 | 94244 | 94559 | 94560 | 94561 | 94562 | 94563 | 94564 | 94566 | 94567 | 94568 | 94569 | 94570 | 94571 | 94572 | 94573 | 94574 | 94575 | 94576 | 94577