Bugzilla – Attachment 90079 Details for
Bug 18308
Default value of minPasswordLength should be increased
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18308: Removed warns and moved password length warning to template
Bug-18308-Removed-warns-and-moved-password-length-.patch (text/plain), 2.61 KB, created by
Liz Rea
on 2019-05-24 18:02:21 UTC
(
hide
)
Description:
Bug 18308: Removed warns and moved password length warning to template
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2019-05-24 18:02:21 UTC
Size:
2.61 KB
patch
obsolete
>From 9fb5f743eed2bd21932be0f1aaeb64e141d97dd4 Mon Sep 17 00:00:00 2001 >From: Hayley Mapley <hayleymapley@catalyst.net.nz> >Date: Fri, 26 Apr 2019 14:52:53 +1200 >Subject: [PATCH] Bug 18308: Removed warns and moved password length warning to > template > >Sponsored-by: Catalyst IT > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> >--- > installer/onboarding.pl | 1 - > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- > members/memberentry.pl | 3 +-- > 3 files changed, 2 insertions(+), 4 deletions(-) > >diff --git a/installer/onboarding.pl b/installer/onboarding.pl >index 3d2e2a4597..eebfe80759 100755 >--- a/installer/onboarding.pl >+++ b/installer/onboarding.pl >@@ -146,7 +146,6 @@ if ( $step == 3 ) { > > if ( $op eq 'set_validate_min_password_length' ) { > my $minPasswordLength = $input->param('pref_minPasswordLength'); >- warn $minPasswordLength; > C4::Context->set_preference( 'minPasswordLength', $minPasswordLength ); > unless ($@) { > push @messages, { code => 'success_on_update_minPasswordLength_syspref' }; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 2ec1d47cdc..49b05ea433 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -133,7 +133,7 @@ > > [% IF passwordwarning %] > <div class="dialog alert"> >- <p><strong> Warning: </strong> [% passwordwarning | html %]</p> >+ <p><strong> Warning: </strong>Your minPasswordLength system preference is less than 8 characters. This means library patrons can potentially set passwords which are vulnerable to cracking. Please set your minPasswordLength syspref to 8 or more characters.</p> > </div> > [% END %] > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 2040e57de3..2b3418c49b 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -173,9 +173,8 @@ $category_type="A" unless $category_type; # FIXME we should display a error mess > > #Check passwords > my $minPasswordLength = C4::Context->preference('minPasswordLength'); >-warn $minPasswordLength; > if ($minPasswordLength < 8) { >- warn my $warning = "Your minPasswordLength system preference is less than 8 characters this means library patrons can potentially set passwords which are vulnerable to cracking. Please set your minPasswordLength syspref to 8 or more characters"; >+ my $warning = 1; > $template->param("passwordwarning"=>$warning); > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18308
:
68374
|
68381
|
68451
|
69318
|
69319
|
69320
|
69321
|
69323
|
69324
|
69459
|
69461
|
69462
|
87124
|
87125
|
87126
|
87128
|
87129
|
87339
|
87340
|
87564
|
87572
|
87573
|
87747
|
87959
|
87960
|
87961
|
87962
|
87963
|
87964
|
87966
|
88010
|
88011
|
88012
|
88013
|
88014
|
88242
|
88243
|
88306
|
88307
|
88308
|
88309
|
88310
|
88311
|
88312
|
88313
|
88314
|
88315
|
88316
|
88317
|
88318
|
88319
|
88320
|
88321
|
88840
|
90079
|
103617
|
104235
|
104236
|
104351