Attachment 90150 Details for Bug 22835 – Bug 22835: (follow-up) Remove comented code

[patch] Bug 22835: (follow-up) Remove comented code

Bug-22835-follow-up-Remove-comented-code.patch (text/plain), 1.62 KB, created by Kyle M Hall (khall) on 2019-05-28 11:37:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-05-28 11:37:19 UTC

Size: 1.62 KB

patch

obsolete

>From 03509b0b840a34dfb67c8750e305139d701134bd Mon Sep 17 00:00:00 2001
>From: Agustin Moyano <agustinmoyano@theke.io>
>Date: Thu, 16 May 2019 00:09:38 -0300
>Subject: [PATCH] Bug 22835: (follow-up) Remove comented code
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/REST/Plugin/PluginRoutes.pm | 3 +--
> Koha/REST/V1/Static.pm           | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/Koha/REST/Plugin/PluginRoutes.pm b/Koha/REST/Plugin/PluginRoutes.pm
>index 43ac913332..273d5df708 100644
>--- a/Koha/REST/Plugin/PluginRoutes.pm
>+++ b/Koha/REST/Plugin/PluginRoutes.pm
>@@ -48,13 +48,12 @@ sub register {
>     if (   C4::Context->preference('UseKohaPlugins')
>         && C4::Context->config("enable_plugins") )
>     {
>+        # plugin needs to define a namespace
>         @plugins = Koha::Plugins->new()->GetPlugins(
>             {
>                 method => 'api_namespace',
>             }
>         );
>-        # plugin needs to define a namespace
>-        #@plugins = grep { $_->api_namespace } @plugins;
>     }
> 
>     foreach my $plugin ( @plugins ) {
>diff --git a/Koha/REST/V1/Static.pm b/Koha/REST/V1/Static.pm
>index 0883a378c2..e64fd8344b 100644
>--- a/Koha/REST/V1/Static.pm
>+++ b/Koha/REST/V1/Static.pm
>@@ -68,7 +68,6 @@ sub get {
>         return try {
>             my $asset = Mojo::Asset::File->new(path => join('/', $basepath, $relpath));
>             return $c->render({ status => 404, openapi => { error => 'File not found' } }) unless $asset->is_file;
>-            # $c->res->headers->content_type("image/jpeg");
>             return $c->reply->asset($asset);
>         }
>         catch {
>-- 
>2.20.1 (Apple Git-117)

Actions: View | Diff | Splinter Review

Attachments on bug 22835: 89262 | 89263 | 89280 | 89663 | 89664 | 89812 | 90148 | 90149 | 90150