Attachment 90158 Details for Bug 14242 – Bug 14242: (follow up) renaming syspref

[patch] Bug 14242: (follow up) renaming syspref

Bug-14242-follow-up-renaming-syspref.patch (text/plain), 6.41 KB, created by Owen Leonard on 2019-05-28 15:09:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-05-28 15:09:39 UTC

Size: 6.41 KB

patch

obsolete

>From 69e3f137a5478fb55f776fa80c1fdd17959c73a3 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Fri, 30 Sep 2016 00:48:04 +0000
>Subject: [PATCH] Bug 14242: (follow up) renaming syspref
>
>OPACAutoFill -> OPACSuggestionAutoFill
>
>Signed-off-by: Marc <veron@veron.ch>
>---
> installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql  | 2 +-
> installer/data/mysql/sysprefs.sql                                 | 2 +-
> .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref     | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc         | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt      | 8 ++++----
> 5 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql b/installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql
>index 3cb4ffb..1abb6ab 100644
>--- a/installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql
>+++ b/installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql
>@@ -1 +1 @@
>-INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, `explanation`,`type`) VALUES ('OPACAutoFill', '0', NULL, 'Automaticly fill forms with data from Google Books API','YesNo');
>+INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, `explanation`,`type`) VALUES ('OPACSuggestionAutoFill', '0', NULL, 'Automaticly fill forms with data from Google Books API','YesNo');
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index bd4541b..5e03367 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -340,7 +340,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('OAI-PMH:DeletedRecord','persistent','Koha\'s deletedbiblio table will never be deleted (persistent), might be deleted (transient), or will never have any data in it (no)','transient|persistent|no','Choice'),
> ('OAI-PMH:MaxCount','50',NULL,'OAI-PMH maximum number of records by answer to ListRecords and ListIdentifiers queries','Integer'),
> ('OPACAcquisitionDetails','0','','Show the acquisition details at the OPAC','YesNo'),
>-('OPACAutoFill','0',NULL,'Automaticly fill forms with data from Google Books API','YesNo'),
>+('OPACSuggestionAutoFill','0',NULL,'Automaticly fill forms with data from Google Books API','YesNo'),
> ('OpacAddMastheadLibraryPulldown','0','','Adds a pulldown menu to select the library to search on the opac masthead.','YesNo'),
> ('OpacAdvSearchMoreOptions','pubdate,itemtype,language,subtype,sorting,location','Show search options for the expanded view (More options)','pubdate|itemtype|language|subtype|sorting|location','multiple'),
> ('OpacAdvSearchOptions','pubdate,itemtype,language,sorting,location','Show search options','pubdate|itemtype|language|subtype|sorting|location','multiple'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index fcd6d43..aa4399a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -530,7 +530,7 @@ OPAC:
>                   no: Don't display
>             - a branch selection list for news items in the OPAC.
>         -
>-            - pref: OPACAutoFill
>+            - pref: OPACSuggestionAutoFill
>               default: 0
>               choices:
>                   yes: Enable
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>index c0d4936..76882da 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>@@ -250,7 +250,7 @@ $.widget.bridge('uitooltip', $.ui.tooltip);
>     </script>
> [% END %]
> 
>-[% IF ( Koha.Preference('OPACAutoFill') ) %]
>+[% IF ( Koha.Preference('OPACSuggestionAutoFill') ) %]
>     <script type="text/javascript" src="[% interface %]/[% theme %]/js/autofill.js"></script>
> [% END %]
> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index 134079d..02d6386 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -41,12 +41,12 @@
>                             <p>Only certain fields (marked in red) are required, but the more information you enter the easier it will be for the librarians to find the title you're requesting. The "Notes" field can be used to provide any additional information.</p>
> 
>                             <form action="/cgi-bin/koha/opac-suggestions.pl" method="post" id="add_suggestion_form">
>-                                [% IF Koha.Preference( 'OPACAutoFill' ) %]
>+                                [% IF Koha.Preference( 'OPACSuggestionAutoFill' ) %]
>                                 <fieldset class="rows well" style="margin-bottom: 3em;padding-top: 5px;">
>                                     <label for="isbn">Standard number (ISBN, ISSN or other):</label><input type="text" id="isbn" name="isbn"  maxlength="80" />
>                                 </fieldset>
>                                 [% END %]
>-                                    <fieldset class="rows [% IF Koha.Preference( 'OPACAutoFill' ) %]well[% END %]">
>+                                    <fieldset class="rows [% IF Koha.Preference( 'OPACSuggestionAutoFill' ) %]well[% END %]">
>                                     <ol>
>                                         <li>
>                                             [% IF ( title_required ) %]
>@@ -81,7 +81,7 @@
>                                             </div>
>                                         </li>
> 
>-                                        [% IF NOT Koha.Preference( 'OPACAutoFill' ) %]
>+                                        [% IF NOT Koha.Preference( 'OPACSuggestionAutoFill' ) %]
>                                             <li>
>                                                 [% IF ( isbn_required ) %]
>                                                     <label for="isbn" class="required">Standard number (ISBN, ISSN or other):</label>
>@@ -405,7 +405,7 @@
>         }
>     [% END %]
> 
>-    [% IF Koha.Preference( 'OPACAutoFill' ) %]
>+    [% IF Koha.Preference( 'OPACSuggestionAutoFill' ) %]
>     $(function() {
>         $('#isbn').autofill({
>             'volumeInfo.title': {target: 'title', effect: 'flash'},
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14242: 42002 | 55949 | 56061 | 56062 | 56070 | 56071 | 56072 | 56073 | 56074 | 56075 | 84760 | 84761 | 84762 | 84763 | 84764 | 84840 | 85031 | 85032 | 85033 | 85034 | 85035 | 89643 | 89662 | 90157 | 90158 | 90159 | 90160 | 90161 | 90162 | 90250 | 90251 | 90252 | 90253 | 90254 | 90255 | 103527 | 103528 | 103529 | 103530 | 103531 | 103532 | 103533 | 108695 | 108696 | 108697 | 108698 | 108699 | 108700 | 108701 | 110141 | 110142 | 110143 | 110144 | 110145 | 110146 | 110147 | 110148 | 110493 | 110494 | 110495 | 110496 | 110497 | 110498 | 110499 | 110500 | 110501 | 110990 | 112597 | 112598 | 112599 | 112600 | 112601 | 112602 | 112603 | 112604 | 112605 | 112606 | 112607 | 113162 | 113163 | 113164 | 113165 | 113166 | 113167 | 116620 | 116712 | 116968 | 116989 | 125380 | 125381 | 125382 | 131219 | 131220 | 131221 | 131222 | 133985 | 133986 | 133987 | 133988 | 134273 | 134274 | 134275 | 134276 | 134277 | 134278