Bugzilla – Attachment 90178 Details for
Bug 22907
Cannot add new suggestion with strict SQL modes turned on
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22907: Fix new suggestion with strict sql modes
Bug-22907-Fix-new-suggestion-with-strict-sql-modes.patch (text/plain), 2.24 KB, created by
Marcel de Rooy
on 2019-05-29 12:04:53 UTC
(
hide
)
Description:
Bug 22907: Fix new suggestion with strict sql modes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-05-29 12:04:53 UTC
Size:
2.24 KB
patch
obsolete
>From 83b2d1a89cc89230fc0f47b4283ed76585995dbc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 14 May 2019 12:06:24 -0500 >Subject: [PATCH] Bug 22907: Fix new suggestion with strict sql modes >Content-Type: text/plain; charset=utf-8 > >With sql_strict_modes turned on, if you try to create a new suggestion >you will get: >Incorrect integer value: '' for column '$INT_COLUMN' at row 1 > >Test plan: >Turn on strict_sql_modes, create a new suggestion, then edit it. > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> > >JD: Edit after SO, remove unecessary changes (not related to this bug) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Suggestions.pm | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm >index 05a7d20616..495d380e87 100644 >--- a/C4/Suggestions.pm >+++ b/C4/Suggestions.pm >@@ -455,12 +455,12 @@ sub NewSuggestion { > > $suggestion->{suggesteddate} = dt_from_string unless $suggestion->{suggesteddate}; > >- my $rs = Koha::Database->new->schema->resultset('Suggestion'); >- my $new_id = $rs->create($suggestion)->id; >+ my $suggestion_object = Koha::Suggestion->new( $suggestion )->store; >+ my $suggestion_id = $suggestion_object->suggestionid; > > my $emailpurchasesuggestions = C4::Context->preference("EmailPurchaseSuggestions"); > if ($emailpurchasesuggestions) { >- my $full_suggestion = GetSuggestion( $new_id ); >+ my $full_suggestion = GetSuggestion( $suggestion_id); # We should not need to refetch it! > if ( > my $letter = C4::Letters::GetPreparedLetter( > module => 'suggestions', >@@ -506,7 +506,7 @@ sub NewSuggestion { > } > } > >- return $new_id; >+ return $suggestion_id; > } > > =head2 ModSuggestion >@@ -543,9 +543,9 @@ sub ModSuggestion { > or $suggestion->{$field} eq '' ); > } > >- my $rs = Koha::Database->new->schema->resultset('Suggestion')->find($suggestion->{suggestionid}); >+ my $suggestion_object = Koha::Suggestions->find( $suggestion->{suggestionid} ); > eval { # FIXME Must raise an exception instead >- $rs->update($suggestion); >+ $suggestion_object->set($suggestion)->store; > }; > return 0 if $@; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22907
:
89763
|
89764
|
89767
|
89768
|
89865
|
89872
|
89873
|
89874
|
89875
|
90168
|
90169
|
90170
|
90177
| 90178 |
90179
|
90180