Bugzilla – Attachment 90185 Details for
Bug 22996
Move barcode separators to a preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22996: Add new preference BarcodeSeparators
Bug-22996-Add-new-preference-BarcodeSeparators.patch (text/plain), 3.30 KB, created by
Marcel de Rooy
on 2019-05-29 13:42:47 UTC
(
hide
)
Description:
Bug 22996: Add new preference BarcodeSeparators
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-05-29 13:42:47 UTC
Size:
3.30 KB
patch
obsolete
>From 0e597a6ee3d843b9e2b0836ba00158f060e51c76 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 28 May 2019 14:47:35 +0000 >Subject: [PATCH] Bug 22996: Add new preference BarcodeSeparators >Content-Type: text/plain; charset=utf-8 > >The pref value is used within a regex character class like [pref]. >This means that we should precede hyphen with a backslash; the pipe char >or dot does not need escaping. > >Test plan: >Run new install or upgrade. >Check pref value. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/atomicupdate/bug_22996.perl | 6 ++++++ > installer/data/mysql/sysprefs.sql | 1 + > .../intranet-tmpl/prog/en/modules/admin/preferences/tools.pref | 6 ++++++ > 3 files changed, 13 insertions(+) > create mode 100644 installer/data/mysql/atomicupdate/bug_22996.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_22996.perl b/installer/data/mysql/atomicupdate/bug_22996.perl >new file mode 100644 >index 0000000000..c90d71b432 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_22996.perl >@@ -0,0 +1,6 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do( q/INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES (?, ?, ?, ?, ?)/, undef, 'BarcodeSeparators','\s\r\n','','Splitting characters for barcodes','Free' ); >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 22996 - Add pref BarcodeSeparators)\n"; >+} >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index c8086043c9..3bb7f724ba 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -85,6 +85,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('BakerTaylorEnabled','0','','Enable or disable all Baker & Taylor features.','YesNo'), > ('BakerTaylorPassword','','','Baker & Taylor Password for Content Cafe (external content)','Free'), > ('BakerTaylorUsername','','','Baker & Taylor Username for Content Cafe (external content)','Free'), >+('BarcodeSeparators','\\s\\r\\n','','Splitting characters for barcodes','Free'), > ('BasketConfirmations','1','always ask for confirmation.|do not ask for confirmation.','When closing or reopening a basket,','Choice'), > ('BatchCheckouts','0','','Enable or disable batch checkouts','YesNo'), > ('BatchCheckoutsValidCategories','',NULL,'Patron categories allowed to checkout in a batch','Free'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref >index 52dfd8509c..1d4f2965ef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref >@@ -1,4 +1,10 @@ > Tools: >+ Barcodes: >+ - >+ - Split barcodes on the following separator chars >+ - pref: BarcodeSeparators >+ default: '\s\r\n' >+ - "in batch item modification and inventory.<br/>Note: Type \\r for carriage return, \\n for newline and \\s for whitespace. Possible candidates to include also are pipe char |, hyphen (precede with backslash), comma, semicolon, dot, etc." > Batch item: > - > - Process up to >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22996
:
90155
|
90156
|
90185
|
90186
|
92636
|
92637
|
92668
|
92669