Attachment 90211 Details for Bug 22877 – Bug 22877: Prevent double overdue processing for lost and returned

[patch] Bug 22877: Prevent double overdue processing for lost and returned

Bug-22877-Prevent-double-overdue-processing-for-lo.patch (text/plain), 1.24 KB, created by Marcel de Rooy on 2019-05-31 06:28:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-05-31 06:28:31 UTC

Size: 1.24 KB

patch

obsolete

>From 7205fd2c6b5882cb03ae461b037f73fbbc47bfa4 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 9 May 2019 15:53:56 +0100
>Subject: [PATCH] Bug 22877: Prevent double overdue processing for lost and
> returned
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Circulation.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index e1b0ed6348..9dd1a23774 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -1960,7 +1960,7 @@ sub AddReturn {
>                 MarkIssueReturned( $borrowernumber, $item->itemnumber, $return_date, $patron->privacy );
>             };
>             unless ( $@ ) {
>-                if ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue ) {
>+                if ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue && !$item->itemlost ) {
>                     _CalculateAndUpdateFine( { issue => $issue, item => $item_unblessed, borrower => $patron_unblessed, return_date => $return_date } );
>                 }
>             } else {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22877: 89505 | 89507 | 89508 | 89509 | 89510 | 89511 | 89512 | 89513 | 89514 | 89516 | 89527 | 89818 | 89819 | 89820 | 89821 | 89858 | 89859 | 89860 | 89861 | 90210 | 90211 | 90212 | 90213