Attachment 90235 Details for Bug 23026 – Bug 23026: Do not double encode CAS url

[patch] Bug 23026: Do not double encode CAS url

Bug-23026-Do-not-double-encode-CAS-url.patch (text/plain), 1.45 KB, created by Nick Clemens (kidclamp) on 2019-05-31 16:38:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-05-31 16:38:01 UTC

Size: 1.45 KB

patch

obsolete

>From a91ce324a5ca37118564bb6339bf3f7f534a732c Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 31 May 2019 16:37:11 +0000
>Subject: [PATCH] Bug 23026: Do not double encode CAS url
>
>It is already escaped correctly in
>C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape
>
>Note that shibbolethLoginUrl is not and must be url escaped in template
>("be consistent, they said")
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
>index 7533b0cb8b..b46a5425f5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
>@@ -96,14 +96,14 @@
> [% END %]
> 
> [% IF ( casServerUrl ) %]
>- <a href="[% casServerUrl | url %]">If you have a CAS account, please click here to login</a>.
>+ <a href="[% casServerUrl | $raw %]">If you have a CAS account, please click here to login</a>.
> [% END %]
> 
> [% IF ( casServersLoop ) %]
> If you have a CAS account, please choose against which one you would like to authenticate:
> <ul>
> [% FOREACH casServer IN casServersLoop %]
>- <li><a href="[% casServer.value | url %]">[% casServer.name | html %]</a></li>
>+ <li><a href="[% casServer.value | $raw %]">[% casServer.name | html %]</a></li>
> [% END %]
> [% END %]
> [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23026: 90235