Attachment 90242 Details for Bug 22952 – Bug 22952: Markup error in OPAC suggestions template

[patch] Bug 22952: Markup error in OPAC suggestions template

Bug-22952-Markup-error-in-OPAC-suggestions-templat.patch (text/plain), 2.63 KB, created by Bin Wen on 2019-05-31 18:04:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bin Wen

Created: 2019-05-31 18:04:43 UTC

Size: 2.63 KB

patch

obsolete

>From 204efca0928e1c33dcc378e277c14ca5ef391153 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 21 May 2019 16:00:18 +0000
>Subject: [PATCH] Bug 22952: Markup error in OPAC suggestions template
>
>This patch makes a minor correction to the OPAC suggestions template in
>order to quiet an error returned by the HTML validator.
>
>To reproduce the problem you should have the 'suggestion' system
>preference turned on, and you should be logged in to the OPAC as a user
>who has submitted one or more suggestions. View the "your purchase
>suggestions" page in the OPAC. Run the page through the W3C validation
>service: https://validator.w3.org. Either by pasting in the URL for the
>search results (if web accessible) or by viewing source, copying, and
>pasting into "Validate by Direct Input."
>
>This patch specifically addresses these errors:
>
> - "End tag div seen, but there were open elements."
> - "Unclosed element span."
>
>To test, apply the patch and try again to reproduce the validation
>errors. Those errors should no longer be present. There should be no
>visible change to the page.
>
>Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
>Signed-off-by: Bin Wen <bin.wen@inlibro.com>
>---
> .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index 5ce43f2718..2da7660e84 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -267,9 +267,11 @@
> 
> [% IF ( loggedinusername ) %]
> <div id="selections-toolbar" class="toolbar">
>- |
>- Select suggestions to: 
>- 
>+ |
>+ 
>+ Select suggestions to: 
>+ 
>+ 
> </div>
> [% END %]
> 
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 22952: 89946 | 90092 | 90242 | 90249 | 90259 | 90267