Attachment 90261 Details for Bug 22954 – Bug 22954: Minor markup error in OPAC messaging template

[patch] Bug 22954: Minor markup error in OPAC messaging template

Bug-22954-Minor-markup-error-in-OPAC-messaging-tem.patch (text/plain), 2.15 KB, created by Arthur Bousquet on 2019-05-31 20:52:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Arthur Bousquet

Created: 2019-05-31 20:52:47 UTC

Size: 2.15 KB

patch

obsolete

>From 1767ceeeb5dc5f13cc13ec3612a4d57dfa3e2385 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 21 May 2019 16:59:38 +0000
>Subject: [PATCH] Bug 22954: Minor markup error in OPAC messaging template
>
>This patch corrects a minor error in opac-messaging.tt in order to
>quiet errors returned by the HTML validator.
>
>To reproduce the problem you should have the
>EnhancedMessagingPreferencesOPAC  system preference enabled. Log in
>to the OPAC and go to the "your messaging" page. Run the page through
>the W3C validation service: https://validator.w3.org. Either by pasting
>in the URL for the search results (if web accessible) or by viewing
>source, copying, and pasting into "Validate by Direct Input."
>
>This patch addresses this error:
>
> - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring
>   the slash and treating as a start tag."
>
>To test, apply the patch and try again to reproduce the validation
>error. The error should no longer be present. There should be no
>visible change to the page.
>
>Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
>Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>index 9f4e6f7..9b211ce 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>@@ -141,7 +141,7 @@
>                             [% IF ( SMSSendDriver == 'Email' ) %]
>                                 <ol><li>
>                                     <label for="sms_provider_id">SMS provider:</label>
>-                                    <select id="sms_provider_id" name="sms_provider_id"/>
>+                                    <select id="sms_provider_id" name="sms_provider_id">
>                                         <option value="">Unknown</option>
>                                         [% FOREACH s IN sms_providers %]
>                                             [% IF s.id == sms_provider_id %]
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 22954: 89948 | 90258 | 90261 | 90268