Attachment 90266 Details for Bug 22948 – Bug 22948: Markup error in OPAC bibliographic detail template

[patch] Bug 22948: Markup error in OPAC bibliographic detail template

Bug-22948-Markup-error-in-OPAC-bibliographic-detai.patch (text/plain), 2.13 KB, created by Katrin Fischer on 2019-06-02 13:32:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-06-02 13:32:53 UTC

Size: 2.13 KB

patch

obsolete

>From c8808a782ac523c607832a34d0772c2303de2a25 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 21 May 2019 14:27:40 +0000
>Subject: [PATCH] Bug 22948: Markup error in OPAC bibliographic detail template
>
>This patch addresses one markup problem in opac-detail.tt which triggers
>a validation error.
>
>To reproduce the problem, view the normal bibliographic detail page for
>a record in the OPAC. Run the page through the W3C validation service:
>https://validator.w3.org. Either by pasting in the URL for the search
>results (if web accessible) or by viewing source, copying, and pasting
>into "Validate by Direct Input."
>
>This patch addresses one specific error:
>
> - "The aria-labelledby attribute must point to an element in the same
>   document."
>
>To test, apply the patch and try again to reproduce the validation
>errors. Those errors should no longer be present. There should be no
>visible change to the page.
>
>Test the "Save record -> Dublin Core" menu item. It should trigger a
>modal window.
>
>Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
>Signed-off-by: Bin Wen <bin.wen@inlibro.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
>index e1c645d687..9384e9416c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
>@@ -90,7 +90,7 @@
> </ul>
> 
> 
>-<div class="modal hide" id="exportModal_" tabindex="-1" role="dialog" aria-labelledby="exportLabelexportModal_" aria-hidden="true">
>+<div class="modal hide" id="exportModal_" tabindex="-1" role="dialog" aria-labelledby="exportModalLabel" aria-hidden="true">
>     <div class="modal-header">
>         <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">&times;</button>
>         <h3 class="modal-title" id="exportModalLabel">Exporting to Dublin Core...</h3>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22948: 89943 | 90248 | 90257 | 90266