Attachment 90278 Details for Bug 23038 – Bug 23038: Hide expected warnings from tests

[patch] Bug 23038: Hide expected warnings from tests

Bug-23038-Hide-expected-warnings-from-tests.patch (text/plain), 3.36 KB, created by Jonathan Druart on 2019-06-03 16:42:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-06-03 16:42:51 UTC

Size: 3.36 KB

patch

obsolete

>From 8fd383011a03fdb476ac2987df31f93ac9d71aeb Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 3 Jun 2019 11:40:31 -0500
>Subject: [PATCH] Bug 23038: Hide expected warnings from tests
>
>When tests are ran, there are 2 warnings that are expected and raised by
>DBI.
>As they are expected they must be correctly caught and not displayed.
>
>We could have reconnect with PrintError turned off, but then reconnect
>with it on.
>
>Test plan:
>% prove t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Suggestions.t
>Must not display DBI warnings
>---
> t/db_dependent/Circulation/MarkIssueReturned.t | 16 ++++++++++++----
> t/db_dependent/Suggestions.t                   | 22 ++++++++++++++++------
> 2 files changed, 28 insertions(+), 10 deletions(-)
>
>diff --git a/t/db_dependent/Circulation/MarkIssueReturned.t b/t/db_dependent/Circulation/MarkIssueReturned.t
>index 70924bca39..6544ffbb65 100644
>--- a/t/db_dependent/Circulation/MarkIssueReturned.t
>+++ b/t/db_dependent/Circulation/MarkIssueReturned.t
>@@ -174,10 +174,18 @@ subtest 'Manually pass a return date' => sub {
> 
>     $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode );
> 
>-    throws_ok
>-        { $issue_id = C4::Circulation::MarkIssueReturned( $patron->borrowernumber, $item->itemnumber, 'bad_date', 0 ); }
>-        'Koha::Exceptions::Object::BadValue',
>-        'An exception is thrown on bad date';
>+    {
>+        # Hiding the expected warning displayed by DBI
>+        # DBD::mysql::st execute failed: Incorrect datetime value: 'bad_date' for column 'returndate'
>+        my $stderr;
>+        local *STDERR;
>+        open STDERR, '>', '/dev/null';
>+        throws_ok
>+            { $issue_id = C4::Circulation::MarkIssueReturned( $patron->borrowernumber, $item->itemnumber, 'bad_date', 0 ); }
>+            'Koha::Exceptions::Object::BadValue',
>+            'An exception is thrown on bad date';
>+        close STDERR;
>+    }
> 
>     $schema->storage->txn_rollback;
> };
>diff --git a/t/db_dependent/Suggestions.t b/t/db_dependent/Suggestions.t
>index 16638aac78..e22b621af7 100644
>--- a/t/db_dependent/Suggestions.t
>+++ b/t/db_dependent/Suggestions.t
>@@ -250,12 +250,22 @@ $messages = C4::Letters::GetQueuedMessages({
> });
> is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is email if the borrower has an email');
> 
>-$mod_suggestion4->{manageddate} = 'invalid date!';
>-ModSuggestion($mod_suggestion4);
>-$messages = C4::Letters::GetQueuedMessages({
>-    borrowernumber => $borrowernumber2
>-});
>-is (scalar(@$messages), 1, 'No new letter should have been generated if the update raised an error');
>+{
>+    # Hiding the expected warning displayed by DBI
>+    # DBD::mysql::st execute failed: Incorrect date value: 'invalid date!' for column 'manageddate'
>+    my $stderr;
>+    local *STDERR;
>+    open STDERR, '>', '/dev/null';
>+
>+    $mod_suggestion4->{manageddate} = 'invalid date!';
>+    ModSuggestion($mod_suggestion4);
>+    $messages = C4::Letters::GetQueuedMessages({
>+        borrowernumber => $borrowernumber2
>+    });
>+
>+    close STDERR;
>+    is (scalar(@$messages), 1, 'No new letter should have been generated if the update raised an error');
>+}
> 
> is( GetSuggestionInfo(), undef, 'GetSuggestionInfo without the suggestion id returns undef' );
> $suggestion = GetSuggestionInfo($my_suggestionid);
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23038: 90278 | 90678 | 94041 | 94100 | 94101