Bugzilla – Attachment 90318 Details for
Bug 15985
Include checkout library in fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15985: Add new method Koha::Account::Line::checkout
Bug-15985-Add-new-method-KohaAccountLinecheckout.patch (text/plain), 3.92 KB, created by
Kyle M Hall (khall)
on 2019-06-04 12:13:27 UTC
(
hide
)
Description:
Bug 15985: Add new method Koha::Account::Line::checkout
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-06-04 12:13:27 UTC
Size:
3.92 KB
patch
obsolete
>From 8bdb4192c78465130d4014f83999b8c130808616 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatetsolutions.com> >Date: Fri, 9 Mar 2018 10:43:41 -0500 >Subject: [PATCH] Bug 15985: Add new method Koha::Account::Line::checkout > >--- > Koha/Account/Line.pm | 1 + > Koha/Old/Checkout.pm | 2 +- > Koha/Old/Checkouts.pm | 2 +- > Koha/Schema/Result/OldIssue.pm | 10 +++++++ > t/db_dependent/Koha/Account/Lines.t | 46 ++++++++++++++++++++++++++++- > 5 files changed, 58 insertions(+), 3 deletions(-) > >diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm >index 54ca0a3063..15619d0658 100644 >--- a/Koha/Account/Line.pm >+++ b/Koha/Account/Line.pm >@@ -26,6 +26,7 @@ use Koha::Account::Offsets; > use Koha::Database; > use Koha::Exceptions::Account; > use Koha::Items; >+use Koha::Checkouts; > > use base qw(Koha::Object); > >diff --git a/Koha/Old/Checkout.pm b/Koha/Old/Checkout.pm >index d602a63602..e333d082d0 100644 >--- a/Koha/Old/Checkout.pm >+++ b/Koha/Old/Checkout.pm >@@ -19,7 +19,7 @@ use Modern::Perl; > > use Koha::Database; > >-use base qw(Koha::Object); >+use base qw(Koha::Checkout); > > =head1 NAME > >diff --git a/Koha/Old/Checkouts.pm b/Koha/Old/Checkouts.pm >index c7f1a6a220..1b5e21843a 100644 >--- a/Koha/Old/Checkouts.pm >+++ b/Koha/Old/Checkouts.pm >@@ -20,7 +20,7 @@ use Modern::Perl; > use Koha::Database; > use Koha::Old::Checkout; > >-use base qw(Koha::Objects); >+use base qw(Koha::Checkouts); > > sub _type { > return 'OldIssue'; >diff --git a/Koha/Schema/Result/OldIssue.pm b/Koha/Schema/Result/OldIssue.pm >index 2d560896fe..f3fb1110f8 100644 >--- a/Koha/Schema/Result/OldIssue.pm >+++ b/Koha/Schema/Result/OldIssue.pm >@@ -233,6 +233,16 @@ __PACKAGE__->belongs_to( > }, > ); > >+__PACKAGE__->belongs_to( >+ "branch", >+ "Koha::Schema::Result::Branch", >+ { branchcode => "branchcode" }, >+ { >+ is_deferrable => 1, >+ join_type => "LEFT", >+ }, >+); >+ > > # Created by DBIx::Class::Schema::Loader v0.07046 @ 2019-04-10 19:55:44 > # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:E2N2paWcCHg916100ry+2A >diff --git a/t/db_dependent/Koha/Account/Lines.t b/t/db_dependent/Koha/Account/Lines.t >index 3856f6ef14..35df033af7 100755 >--- a/t/db_dependent/Koha/Account/Lines.t >+++ b/t/db_dependent/Koha/Account/Lines.t >@@ -19,7 +19,7 @@ > > use Modern::Perl; > >-use Test::More tests => 8; >+use Test::More tests => 9; > use Test::Exception; > > use C4::Circulation qw/AddIssue AddReturn/; >@@ -561,4 +561,48 @@ subtest "void() tests" => sub { > $schema->storage->txn_rollback; > }; > >+subtest 'checkout' => sub { >+ plan tests => 1; >+ >+ $schema->storage->txn_begin; >+ >+ my $library = $builder->build( { source => 'Branch' } ); >+ my $biblioitem = $builder->build( { source => 'Biblioitem' } ); >+ my $patron = $builder->build( { source => 'Borrower' } ); >+ my $item = Koha::Item->new( >+ { >+ biblionumber => $biblioitem->{biblionumber}, >+ biblioitemnumber => $biblioitem->{biblioitemnumber}, >+ homebranch => $library->{branchcode}, >+ holdingbranch => $library->{branchcode}, >+ barcode => 'some_barcode_13', >+ itype => 'BK', >+ } >+ )->store; >+ >+ my $checkout = Koha::Checkout->new( >+ { >+ borrowernumber => $patron->{borrowernumber}, >+ itemnumber => $item->itemnumber, >+ branchcode => $library->{branchcode}, >+ } >+ )->store; >+ >+ my $line = Koha::Account::Line->new( >+ { >+ borrowernumber => $patron->{borrowernumber}, >+ itemnumber => $item->itemnumber, >+ issue_id => $checkout->id, >+ accounttype => "F", >+ amount => 10, >+ interface => 'commandline', >+ } >+ )->store; >+ >+ is( $line->checkout->id, $checkout->id, >+ 'Koha::Account::Line->checkout should return the correct checkout' ); >+ >+ $schema->storage->txn_rollback; >+}; >+ > 1; >-- >2.20.1 (Apple Git-117)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15985
:
58157
|
58163
|
71165
|
72611
|
72612
|
90317
|
90318
|
90364
|
90478
|
97177
|
97178
|
97179
|
97180
|
99821
|
99822
|
99823
|
99824
|
99825
|
103152
|
103153
|
103154
|
103155
|
103156
|
103157
|
104491
|
104492
|
105144
|
105398