Attachment 90325 Details for Bug 10215 – Bug 10215: (follow-up) Fix the failing test

[patch] Bug 10215: (follow-up) Fix the failing test

Bug-10215-follow-up-Fix-the-failing-test.patch (text/plain), 1.53 KB, created by Martin Renvoize (ashimema) on 2019-06-05 11:59:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-06-05 11:59:28 UTC

Size: 1.53 KB

patch

obsolete

>From 86f703f0d450d3bb6012630e11789f004e95d47d Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 5 Jun 2019 12:58:20 +0100
>Subject: [PATCH] Bug 10215: (follow-up) Fix the failing test
>
>We now handle NULL values at the database end and do not expect empty
>strings.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Serials.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t
>index cfad08a9b9..688749fb7a 100755
>--- a/t/db_dependent/Serials.t
>+++ b/t/db_dependent/Serials.t
>@@ -92,8 +92,8 @@ is( $subscriptioninformation->{notes}, $notes, 'NewSubscription should set notes
> is( $subscriptioninformation->{internalnotes}, $internalnotes, 'NewSubscription should set internalnotes' );
> 
> my $subscription_history = C4::Serials::GetSubscriptionHistoryFromSubscriptionId($subscriptionid);
>-is( $subscription_history->{opacnote}, '', 'NewSubscription should not set subscriptionhistory opacnotes' );
>-is( $subscription_history->{librariannote}, '', 'NewSubscription should not set subscriptionhistory librariannotes' );
>+is( $subscription_history->{opacnote}, undef, 'NewSubscription should not set subscriptionhistory opacnotes' );
>+is( $subscription_history->{librariannote}, undef, 'NewSubscription should not set subscriptionhistory librariannotes' );
> 
> my @subscriptions = SearchSubscriptions({string => $subscriptioninformation->{bibliotitle}, orderby => 'title' });
> isa_ok( \@subscriptions, 'ARRAY' );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 10215: 17998 | 17999 | 19247 | 19335 | 85395 | 85400 | 87705 | 90323 | 90324 | 90325 | 90355 | 90356 | 90357