Attachment 9035 Details for Bug 2505 – Bug 2505 : use warnings in smart_rules.pl

[patch] Bug 2505 : use warnings in smart_rules.pl

Bug-2505--use-warnings-in-smartrulespl.patch (text/plain), 1.02 KB, created by Chris Cormack on 2012-04-09 07:32:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2012-04-09 07:32:42 UTC

Size: 1.02 KB

patch

obsolete

>From f16f598f92de2057f19d2363aa5468f8ee9a9551 Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Tue, 7 Jun 2011 14:34:18 +0100
>Subject: [PATCH] Bug 2505 : use warnings in smart_rules.pl
>
>Fix some careless code redeclaring a variable
>declaring a variable in a condition
>so that these don't generate errors
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> admin/smart-rules.pl |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
>index 0b8012f..8e5a2d5 100755
>--- a/admin/smart-rules.pl
>+++ b/admin/smart-rules.pl
>@@ -18,7 +18,7 @@
> # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> 
> use strict;
>-#use warnings; FIXME - Bug 2505
>+use warnings;
> use CGI;
> use C4::Context;
> use C4::Output;
>@@ -28,7 +28,7 @@ use C4::Debug;
> use C4::Branch; # GetBranches
> use C4::Dates qw/format_date format_date_in_iso/;
> 
>-my $input = new CGI;
>+my $input = CGI->new;
> my $dbh = C4::Context->dbh;
> 
> # my $flagsrequired;
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 2505: 686 | 687 | 688 | 689 | 690 | 691 | 692 | 693 | 694 | 695 | 696 | 697 | 698 | 699 | 700 | 701 | 702 | 703 | 704 | 705 | 706 | 707 | 708 | 709 | 2223 | 3884 | 4574 | 8209 | 8317 | 8322 | 8373 | 9034 | 9035 | 9036 | 34442