Attachment 90376 Details for Bug 22585 – Bug 22585: remove double-escape for CAS URL

[patch] Bug 22585: remove double-escape for CAS URL

Bug-22585-remove-double-escape-for-CAS-URL.patch (text/plain), 1.55 KB, created by Nick Clemens (kidclamp) on 2019-06-06 14:32:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-06-06 14:32:59 UTC

Size: 1.55 KB

patch

obsolete

>From 4cdf3909ead487ae55c09d907f6fce519be5f2f5 Mon Sep 17 00:00:00 2001
>From: Justin Rittenhouse <jrittenh@nd.edu>
>Date: Fri, 31 May 2019 16:37:11 +0000
>Subject: [PATCH] Bug 22585: remove double-escape for CAS URL
>
>The return URL that is part of the link to CAS login is double-escaped on the staff login page.
>
>It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
>index 7533b0cb8b..b46a5425f5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
>@@ -96,14 +96,14 @@
> [% END %]
> 
> [% IF ( casServerUrl ) %]
>- <a href="[% casServerUrl | url %]">If you have a CAS account, please click here to login</a>.
>+ <a href="[% casServerUrl | $raw %]">If you have a CAS account, please click here to login</a>.
> [% END %]
> 
> [% IF ( casServersLoop ) %]
> If you have a CAS account, please choose against which one you would like to authenticate:
> <ul>
> [% FOREACH casServer IN casServersLoop %]
>- <li><a href="[% casServer.value | url %]">[% casServer.name | html %]</a></li>
>+ <li><a href="[% casServer.value | $raw %]">[% casServer.name | html %]</a></li>
> [% END %]
> [% END %]
> [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22585: 87036 | 90376 | 90456 | 90554 | 90555