Bugzilla – Attachment 90444 Details for
Bug 23074
Holds table sort does not understand dateformat
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23074: Holds table sort does not understand dateformat
Bug-23074-Holds-table-sort-does-not-understand-dat.patch (text/plain), 2.15 KB, created by
Katrin Fischer
on 2019-06-09 20:08:44 UTC
(
hide
)
Description:
Bug 23074: Holds table sort does not understand dateformat
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-06-09 20:08:44 UTC
Size:
2.15 KB
patch
obsolete
>From 0e338e327f8af87025ebbb8f883682209c7f9205 Mon Sep 17 00:00:00 2001 >From: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> >Date: Fri, 7 Jun 2019 09:44:32 +0300 >Subject: [PATCH] Bug 23074: Holds table sort does not understand dateformat > >Holds table does not sort correctly when the dateformat is eg. DD.MM.YYYY. > >Test plan: >1) Create multiple holds for a patron with different hold creation > and expiration dates, with different years, months and days. >2) Change the dateformat to DD.MM.YYYY. >3) Resort the holds table (in circ/circulation or members/moremember) > by the hold date or expiration date. > The table sorts the date by the day number. >4) Apply patch >5) Redo 3 - the table now sorts correctly. > >Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index 1ca9a627c9..3cc30a2230 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -15,7 +15,7 @@ $(document).ready(function() { > "sDom": "rt", > "columns": [ > { >- "mDataProp": "reservedate_formatted" >+ "data": { _: "reservedate_formatted", "sort": "reservedate" } > }, > { > "mDataProp": function ( oObj ) { >@@ -91,7 +91,7 @@ $(document).ready(function() { > else { return oObj.branchcode.escapeHtml() || ""; } > } > }, >- { "mDataProp": "expirationdate_formatted" }, >+ { "data": { _: "expirationdate_formatted", "sort": "expirationdate" } }, > { > "mDataProp": function( oObj ) { > if ( oObj.priority && parseInt( oObj.priority ) && parseInt( oObj.priority ) > 0 ) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23074
:
90406
|
90420
|
90432
| 90444