Attachment 90484 Details for Bug 23022 – Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER

[patch] Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER

Bug-23022-Remove-the-SQl-mode-NOAUTOCREATEUSER.patch (text/plain), 1.66 KB, created by Mark Tompsett on 2019-06-11 13:28:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2019-06-11 13:28:02 UTC

Size: 1.66 KB

patch

obsolete

>From 1e6dacdfdb95cd7790b8399b752f269c3073040a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 5 Jun 2019 19:11:59 -0500
>Subject: [PATCH] Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER
>
>To make our sql mode list compatible with MySQL 8.0.11
>
>NO_AUTO_CREATE_USER has been removed in MySQL 8.0.11
>https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html
>
>I do not think we needed it.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> Koha/Database.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Database.pm b/Koha/Database.pm
>index ea8a10a9bb..c04c60921c 100644
>--- a/Koha/Database.pm
>+++ b/Koha/Database.pm
>@@ -77,9 +77,9 @@ sub _new_schema {
>         $encoding_query = "set NAMES 'utf8mb4'";
>         $tz_query = qq(SET time_zone = "$tz") if $tz;
>         if ( ( exists $ENV{_} && $ENV{_} =~ m|prove| ) or C4::Context->config('strict_sql_modes') ) {
>-            $sql_mode_query = q{SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'};
>+            $sql_mode_query = q{SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'};
>         } else {
>-            $sql_mode_query = q{SET sql_mode = 'IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'};
>+            $sql_mode_query = q{SET sql_mode = 'IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'};
>         }
>     }
>     elsif ( $db_driver eq 'Pg' ) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23022: 90343 | 90484 | 90607