Attachment 90571 Details for Bug 22744 – Bug 22744: Make checkboxes links

[patch] Bug 22744: Make checkboxes links

Bug-22744-Make-checkboxes-links.patch (text/plain), 2.77 KB, created by Nick Clemens (kidclamp) on 2019-06-13 10:54:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-06-13 10:54:11 UTC

Size: 2.77 KB

patch

obsolete

>From e79f59ef643ade120e286528ef7016d8522de88e Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 10 Jun 2019 13:03:51 +0000
>Subject: [PATCH] Bug 22744: Make checkboxes links
>
>---
> .../prog/en/includes/messaging-preference-form.inc          |  2 +-
> .../intranet-tmpl/prog/js/messaging-preference-form.js      | 13 ++-----------
> 2 files changed, 3 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
>index 30d6e305d7..d1c835ba30 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
>@@ -191,7 +191,7 @@
>       [% END %] -->
> 
>       [% UNLESS ( messaging_form_inactive ) %]
>-      <td><input type="checkbox" class="none" id="none[% messaging_preference.message_attribute_id | html %]" /></td>
>+      <td><a href="#memberentry_messaging_prefs" class="clear_pref" id="clear_[% messaging_preference.message_attribute_id | html %]">Clear</a></td>
>       [% END %]
>     </tr>
>     [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js b/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js
>index 8cb20df7f2..c55ab5db0d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js
>@@ -1,20 +1,12 @@
> $(document).ready(function(){
>-    $(".none").click(function(){
>-        if($(this).prop("checked")){
>+    $(".clear_pref").click(function(){
>             var rowid = $(this).attr("id");
>-            var newid = Number(rowid.replace("none",""));
>+            var newid = Number(rowid.replace("clear_",""));
>             $("#sms"+newid).prop("checked", false);
>             $("#email"+newid).prop("checked", false);
>             $("#phone"+newid).prop("checked", false);
>             $("#digest"+newid).prop("checked", false);
>             $("#rss"+newid).prop("checked", false);
>-        }
>-    });
>-    $(".active_notify").on("change",function(){
>-        var attr_id = $(this).data("attr-id");
>-        if( $(this).prop("checked") ){
>-            $("#none" + attr_id ).prop("checked", false);
>-        }
>     });
>     $("#info_digests").tooltip();
> 
>@@ -36,7 +28,6 @@ $(document).ready(function(){
>                     return;
>                 }
>             }
>-            $(".none").prop("checked", false); // When loading default prefs the "Clear" boxes should be cleared
>             var jqxhr = $.getJSON('/cgi-bin/koha/members/default_messageprefs.pl?categorycode=' + categorycode, function(data) {
>                 $.each(data.messaging_preferences, function(i, item) {
>                     var attrid = item.message_attribute_id;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22744: 88357 | 88534 | 88535 | 90454 | 90568 | 90569 | 90570 | 90571 | 90572 | 90574 | 92642 | 92643 | 92644 | 92645 | 92646 | 92647 | 93109 | 93114 | 93115