Attachment 90628 Details for Bug 22944 – Bug 22944: remove obsolete unit test

[patch] Bug 22944: remove obsolete unit test

Bug-22944-remove-obsolete-unit-test.patch (text/plain), 1.69 KB, created by Arthur Bousquet on 2019-06-14 18:51:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Arthur Bousquet

Created: 2019-06-14 18:51:01 UTC

Size: 1.69 KB

patch

obsolete

>From 18b611d55561e0be5e0c865a8a96c6308514b0cc Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 11 Jun 2019 15:31:45 +0200
>Subject: [PATCH] Bug 22944: remove obsolete unit test
>
>Test 'AnonymiseIssueHistory should not return any error if success' is obsolete,
>previous statement will explode if something went wrong.
>
>Test plan :
>Run t/db_dependent/Koha/Patrons.t
>
>Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com>
>---
> t/db_dependent/Koha/Patrons.t | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index 9933299..a73b8e8 100644
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -910,7 +910,7 @@ subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
>     };
> 
>     subtest 'patron privacy is 0 (forever)' => sub {
>-        plan tests => 3;
>+        plan tests => 2;
> 
>         t::lib::Mocks::mock_preference('IndependentBranches', 0);
>         my $patron = $builder->build(
>@@ -937,8 +937,6 @@ subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
> 
>         my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, dt_from_string('2010-10-10') );
>         is( $returned, 1, 'The item should have been returned' );
>-        my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->anonymise_issue_history( { before => '2010-10-11' } );
>-        is( $rows_affected, 0, 'AnonymiseIssueHistory should not return any error if success' );
> 
>         my $dbh = C4::Context->dbh;
>         my ($borrowernumber_used_to_anonymised) = $dbh->selectrow_array(q|
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 22944: 89932 | 89933 | 90488 | 90628 | 90904 | 90905 | 90906